django/django

View on GitHub
django/contrib/gis/gdal/raster/source.py

Summary

Maintainability
D
3 days
Test Coverage

Function __init__ has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
Open

    def __init__(self, ds_input, write=False):
        self._write = 1 if write else 0
        Driver.ensure_registered()

        # Preprocess json inputs. This converts json strings to dictionaries,
Severity: Minor
Found in django/contrib/gis/gdal/raster/source.py - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File source.py has 366 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import json
import os
import sys
import uuid
from ctypes import (
Severity: Minor
Found in django/contrib/gis/gdal/raster/source.py - About 4 hrs to fix

    GDALRaster has 25 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class GDALRaster(GDALRasterBase):
        """
        Wrap a raster GDAL Data Source object.
        """
        destructor = capi.close_ds
    Severity: Minor
    Found in django/contrib/gis/gdal/raster/source.py - About 2 hrs to fix

      Function transform has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def transform(self, srs, driver=None, name=None, resampling='NearestNeighbour',
      Severity: Minor
      Found in django/contrib/gis/gdal/raster/source.py - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            @y.setter
            def y(self, value):
                gtf = self._raster.geotransform
                gtf[self.indices[self._prop][1]] = value
                self._raster.geotransform = gtf
        Severity: Major
        Found in django/contrib/gis/gdal/raster/source.py and 1 other location - About 2 hrs to fix
        django/contrib/gis/gdal/raster/source.py on lines 42..46

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 56.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            @x.setter
            def x(self, value):
                gtf = self._raster.geotransform
                gtf[self.indices[self._prop][0]] = value
                self._raster.geotransform = gtf
        Severity: Major
        Found in django/contrib/gis/gdal/raster/source.py and 1 other location - About 2 hrs to fix
        django/contrib/gis/gdal/raster/source.py on lines 52..56

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 56.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if isinstance(value, SpatialReference):
                    srs = value
                elif isinstance(value, (int, str)):
                    srs = SpatialReference(value)
                else:
        Severity: Major
        Found in django/contrib/gis/gdal/raster/source.py and 1 other location - About 1 hr to fix
        django/contrib/gis/gdal/raster/source.py on lines 437..442

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 44.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if isinstance(srs, SpatialReference):
                    target_srs = srs
                elif isinstance(srs, (int, str)):
                    target_srs = SpatialReference(srs)
                else:
        Severity: Major
        Found in django/contrib/gis/gdal/raster/source.py and 1 other location - About 1 hr to fix
        django/contrib/gis/gdal/raster/source.py on lines 287..292

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 44.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                    if 'skew' in ds_input:
                        self.skew.x, self.skew.y = ds_input['skew']
        Severity: Minor
        Found in django/contrib/gis/gdal/raster/source.py and 2 other locations - About 30 mins to fix
        django/contrib/gis/gdal/raster/source.py on lines 177..178
        django/contrib/gis/gdal/raster/source.py on lines 180..181

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 32.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                    if 'scale' in ds_input:
                        self.scale.x, self.scale.y = ds_input['scale']
        Severity: Minor
        Found in django/contrib/gis/gdal/raster/source.py and 2 other locations - About 30 mins to fix
        django/contrib/gis/gdal/raster/source.py on lines 177..178
        django/contrib/gis/gdal/raster/source.py on lines 183..184

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 32.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                    if 'origin' in ds_input:
                        self.origin.x, self.origin.y = ds_input['origin']
        Severity: Minor
        Found in django/contrib/gis/gdal/raster/source.py and 2 other locations - About 30 mins to fix
        django/contrib/gis/gdal/raster/source.py on lines 180..181
        django/contrib/gis/gdal/raster/source.py on lines 183..184

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 32.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status