Sign upLogin

django/django

View on GitHub
Star
django/core/mail/__init__.py

Summary

Maintainability
D
2 days
Test Coverage

Function send_mail has 9 arguments (exceeds 4 allowed). Consider refactoring.
Open

def send_mail(
Severity: Major
Found in django/core/mail/__init__.py - About 1 hr to fix

    Function mail_managers has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def mail_managers(
    Severity: Minor
    Found in django/core/mail/__init__.py - About 35 mins to fix

      Function mail_admins has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def mail_admins(
      Severity: Minor
      Found in django/core/mail/__init__.py - About 35 mins to fix

        Function send_mass_mail has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def send_mass_mail(
        Severity: Minor
        Found in django/core/mail/__init__.py - About 35 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          def mail_managers(
    subject, message, fail_silently=False, connection=None, html_message=None
):
    """Send a message to the managers, as defined by the MANAGERS setting."""
    if not settings.MANAGERS:
          Severity: Major
          Found in django/core/mail/__init__.py and 1 other location - About 1 day to fix
          django/core/mail/__init__.py on lines 118..135

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 150.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          def mail_admins(
    subject, message, fail_silently=False, connection=None, html_message=None
):
    """Send a message to the admins, as defined by the ADMINS setting."""
    if not settings.ADMINS:
          Severity: Major
          Found in django/core/mail/__init__.py and 1 other location - About 1 day to fix
          django/core/mail/__init__.py on lines 138..155

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 150.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status