Sign upLogin

django/django

View on GitHub
Star
django/db/migrations/serializer.py

Summary

Maintainability
B
6 hrs
Test Coverage

File serializer.py has 307 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import builtins
import collections.abc
import datetime
import decimal
import enum
Severity: Minor
Found in django/db/migrations/serializer.py - About 3 hrs to fix

    Function serializer_factory has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

    def serializer_factory(value):
    if isinstance(value, Promise):
        value = str(value)
    elif isinstance(value, LazyObject):
        # The unwrapped value is returned as the first item of the arguments
    Severity: Minor
    Found in django/db/migrations/serializer.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function serialize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def serialize(self):
        special_cases = [
            (models.Model, "models.Model", ["from django.db import models"]),
            (types.NoneType, "types.NoneType", ["import types"]),
        ]
    Severity: Minor
    Found in django/db/migrations/serializer.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

                return serializer_cls(value)
    Severity: Major
    Found in django/db/migrations/serializer.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return DeconstructableSerializer(value)
      Severity: Major
      Found in django/db/migrations/serializer.py - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status