django/django

View on GitHub
django/db/models/functions/datetime.py

Summary

Maintainability
D
1 day
Test Coverage

Function resolve_expression has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    def resolve_expression(self, query=None, allow_joins=True, reuse=None, summarize=False, for_save=False):
        copy = super().resolve_expression(query, allow_joins, reuse, summarize, for_save)
        field = copy.lhs.output_field
        # DateTimeField is a subclass of DateField so this works for both.
        assert isinstance(field, (DateField, TimeField)), (
Severity: Minor
Found in django/db/models/functions/datetime.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function convert_value has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def convert_value(self, value, expression, connection):
        if isinstance(self.output_field, DateTimeField):
            if not settings.USE_TZ:
                pass
            elif value is not None:
Severity: Minor
Found in django/db/models/functions/datetime.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(self, expression, kind, output_field=None, tzinfo=None, is_dst=None, **extra):
Severity: Minor
Found in django/db/models/functions/datetime.py - About 45 mins to fix

    Function resolve_expression has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def resolve_expression(self, query=None, allow_joins=True, reuse=None, summarize=False, for_save=False):
    Severity: Minor
    Found in django/db/models/functions/datetime.py - About 35 mins to fix

      Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def __init__(self, expression, output_field=None, tzinfo=None, is_dst=None, **extra):
      Severity: Minor
      Found in django/db/models/functions/datetime.py - About 35 mins to fix

        Function resolve_expression has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def resolve_expression(self, query=None, allow_joins=True, reuse=None, summarize=False, for_save=False):
        Severity: Minor
        Found in django/db/models/functions/datetime.py - About 35 mins to fix

          Function as_sql has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              def as_sql(self, compiler, connection):
                  sql, params = compiler.compile(self.lhs)
                  lhs_output_field = self.lhs.output_field
                  if isinstance(lhs_output_field, DateTimeField):
                      tzname = self.get_tzname()
          Severity: Minor
          Found in django/db/models/functions/datetime.py - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          class TruncTime(TruncBase):
              kind = 'time'
              lookup_name = 'time'
              output_field = TimeField()
          
          
          Severity: Major
          Found in django/db/models/functions/datetime.py and 1 other location - About 4 hrs to fix
          django/db/models/functions/datetime.py on lines 287..297

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 82.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          class TruncDate(TruncBase):
              kind = 'date'
              lookup_name = 'date'
              output_field = DateField()
          
          
          Severity: Major
          Found in django/db/models/functions/datetime.py and 1 other location - About 4 hrs to fix
          django/db/models/functions/datetime.py on lines 300..310

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 82.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status