django/django

View on GitHub
django/forms/formsets.py

Summary

Maintainability
D
2 days
Test Coverage

File formsets.py has 470 lines of code (exceeds 250 allowed). Consider refactoring.
Open

from django.core.exceptions import ValidationError
from django.forms import Form
from django.forms.fields import BooleanField, IntegerField
from django.forms.renderers import get_default_renderer
from django.forms.utils import ErrorList, RenderableFormMixin
Severity: Minor
Found in django/forms/formsets.py - About 7 hrs to fix

    BaseFormSet has 35 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class BaseFormSet(RenderableFormMixin):
        """
        A collection of instances of the same Form class.
        """
    
    
    Severity: Minor
    Found in django/forms/formsets.py - About 4 hrs to fix

      Function ordered_forms has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          def ordered_forms(self):
              """
              Return a list of form in the order specified by the incoming data.
              Raise an AttributeError if ordering is not allowed.
              """
      Severity: Minor
      Found in django/forms/formsets.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function full_clean has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          def full_clean(self):
              """
              Clean all of self.data and populate self._errors and
              self._non_form_errors.
              """
      Severity: Minor
      Found in django/forms/formsets.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function formset_factory has 12 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def formset_factory(
      Severity: Major
      Found in django/forms/formsets.py - About 1 hr to fix

        Function deleted_forms has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            def deleted_forms(self):
                """Return a list of forms that have been marked for deletion."""
                if not self.is_valid() or not self.can_delete:
                    return []
                # construct _deleted_form_indexes which is just a list of form indexes
        Severity: Minor
        Found in django/forms/formsets.py - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function __init__ has 8 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def __init__(
        Severity: Major
        Found in django/forms/formsets.py - About 1 hr to fix

          Function add_fields has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              def add_fields(self, form, index):
                  """A hook for adding extra fields on to each form instance."""
                  initial_form_count = self.initial_form_count()
                  if self.can_order:
                      # Only pre-fill the ordering field for initial forms.
          Severity: Minor
          Found in django/forms/formsets.py - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status