Sign upLogin

django/django

View on GitHub
Star
django/middleware/locale.py

Summary

Maintainability
A
1 hr
Test Coverage

Consider simplifying this complex logical expression.
Open

        if (
            response.status_code == 404
            and not language_from_path
            and i18n_patterns_used
            and prefixed_default_language
Severity: Major
Found in django/middleware/locale.py - About 1 hr to fix

    Function process_response has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def process_response(self, request, response):
        language = translation.get_language()
        language_from_path = translation.get_language_from_path(request.path_info)
        urlconf = getattr(request, "urlconf", settings.ROOT_URLCONF)
        (
    Severity: Minor
    Found in django/middleware/locale.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status