django/django

View on GitHub
django/template/library.py

Summary

Maintainability
D
2 days
Test Coverage

Function parse_bits has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
Open

def parse_bits(parser, bits, params, varargs, varkw, defaults,
               kwonly, kwonly_defaults, takes_context, name):
    """
    Parse bits for template tag helpers simple_tag and inclusion_tag, in
    particular by detecting syntax errors and by extracting positional and
Severity: Minor
Found in django/template/library.py - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File library.py has 265 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import functools
from importlib import import_module
from inspect import getfullargspec, unwrap

from django.utils.html import conditional_escape
Severity: Minor
Found in django/template/library.py - About 2 hrs to fix

    Function filter has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        def filter(self, name=None, filter_func=None, **flags):
            """
            Register a callable as a template filter. Example:
    
            @register.filter
    Severity: Minor
    Found in django/template/library.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function parse_bits has 10 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def parse_bits(parser, bits, params, varargs, varkw, defaults,
    Severity: Major
    Found in django/template/library.py - About 1 hr to fix

      Function tag has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def tag(self, name=None, compile_function=None):
              if name is None and compile_function is None:
                  # @register.tag()
                  return self.tag_function
              elif name is not None and compile_function is None:
      Severity: Minor
      Found in django/template/library.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function render has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def render(self, context):
              """
              Render the specified template and context. Cache the template object
              in render_context to avoid reparsing and loading when used in a for
              loop.
      Severity: Minor
      Found in django/template/library.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function simple_tag has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def simple_tag(self, func=None, takes_context=None, name=None):
              """
              Register a callable as a compiled template tag. Example:
      
              @register.simple_tag
      Severity: Minor
      Found in django/template/library.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def __init__(self, func, takes_context, args, kwargs, target_var):
      Severity: Minor
      Found in django/template/library.py - About 35 mins to fix

        Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def __init__(self, func, takes_context, args, kwargs, filename):
        Severity: Minor
        Found in django/template/library.py - About 35 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def __init__(self, func, takes_context, args, kwargs):
                  self.func = func
                  self.takes_context = takes_context
                  self.args = args
                  self.kwargs = kwargs
          Severity: Major
          Found in django/template/library.py and 1 other location - About 1 hr to fix
          django/db/models/sql/where.py on lines 235..239

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 38.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def __init__(self, func, takes_context, args, kwargs, target_var):
                  super().__init__(func, takes_context, args, kwargs)
                  self.target_var = target_var
          Severity: Minor
          Found in django/template/library.py and 1 other location - About 30 mins to fix
          django/template/library.py on lines 203..205

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 32.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def __init__(self, func, takes_context, args, kwargs, filename):
                  super().__init__(func, takes_context, args, kwargs)
                  self.filename = filename
          Severity: Minor
          Found in django/template/library.py and 1 other location - About 30 mins to fix
          django/template/library.py on lines 186..188

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 32.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status