django/django

View on GitHub
django/utils/tree.py

Summary

Maintainability
A
1 hr
Test Coverage

Function add has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def add(self, data, conn_type, squash=True):
        """
        Combine this tree and the data represented by data using the
        connector conn_type. The combine is done by squashing the node other
        away if possible.
Severity: Minor
Found in django/utils/tree.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

            return data
Severity: Major
Found in django/utils/tree.py - About 30 mins to fix

    There are no issues that match your filters.

    Category
    Status