dockyard/ruby-destroyed_at

View on GitHub

Showing 3 of 3 total issues

Method destroy has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

  def destroy(timestamp = nil)
    with_transaction_returning_status do
      timestamp ||= @marked_for_destruction_at || current_time_from_proper_timezone
      raw_write_attribute(:destroyed_at, timestamp)

Severity: Minor
Found in lib/destroyed_at.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method delete_records has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def delete_records(records, method)
      if method == :destroy
        records.each do |r|
          if r.respond_to?(:destroyed_at) && owner.respond_to?(:destroyed_at)
            r.destroy(owner.destroyed_at)
Severity: Minor
Found in lib/destroyed_at/has_many_association.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _restore_associations has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def _restore_associations
    _reflections.select { |key, value| value.options[:dependent] == :destroy }.keys.each do |key|
      assoc = association(key)
      reload_association = false
      if assoc.options[:through] && assoc.options[:dependent] == :destroy
Severity: Minor
Found in lib/destroyed_at.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language