Sign upLogin

dodekeract/manta-config-engine-app

View on GitHub
Star
source/web/main.jsx

Summary

Maintainability
F
3 days
Test Coverage

Function commandInfo has 178 lines of code (exceeds 25 allowed). Consider refactoring.
Open

window.commandInfo = function (c) {
    switch (c[0]) {
        case "ability":
            var shortMatch = [1, 2, 3, 4, 5, 'ult'];
            var longMatch = ['Ability 1', 'Ability 2', 'Ability 3', 'Ability 4', 'Ability 5', 'Ultimate'];
Severity: Major
Found in source/web/main.jsx - About 7 hrs to fix

    Function commandInfo has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
    Open

    window.commandInfo = function (c) {
    switch (c[0]) {
        case "ability":
            var shortMatch = [1, 2, 3, 4, 5, 'ult'];
            var longMatch = ['Ability 1', 'Ability 2', 'Ability 3', 'Ability 4', 'Ability 5', 'Ultimate'];
    Severity: Minor
    Found in source/web/main.jsx - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File main.jsx has 264 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    // external

var manta = require('dota2-manta-config-engine');

// internal
    Severity: Minor
    Found in source/web/main.jsx - About 2 hrs to fix

      Function onload has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      window.onload = function () {
    ReactDOM.render((
        <ReactRouter.Router>
            <ReactRouter.Redirect from="/" to="home"/>
            <ReactRouter.Route path="/" component={Layout}>
      Severity: Minor
      Found in source/web/main.jsx - About 1 hr to fix

        Avoid too many return statements within this function.
        Open

            return 0;
        Severity: Major
        Found in source/web/main.jsx - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return matcher[c[1]];
          Severity: Major
          Found in source/web/main.jsx - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                            return ['key-open', shortMatch[c[1]], 'Open ' + window.capitalize(c[1])];
            Severity: Major
            Found in source/web/main.jsx - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                              return ['key-open', c[1], 'Open ' + window.capitalize(c[1])];
              Severity: Major
              Found in source/web/main.jsx - About 30 mins to fix

                Function compareVersion has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                window.compareVersion = function (a, b) {
    if (!a) return -1;
    if (!b) return 1;

    var _a = a.split('.');
                Severity: Minor
                Found in source/web/main.jsx - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                                <ReactRouter.Route path="settings" component={Settings}>
                    <ReactRouter.Route path="gameplay" component={SettingsGameplay}/>
                    <ReactRouter.Route path="performance" component={SettingsPerformance}/>
                    <ReactRouter.Route path="engine" component={SettingsEngine}/>
                </ReactRouter.Route>
                Severity: Major
                Found in source/web/main.jsx and 2 other locations - About 3 hrs to fix
                source/web/main.jsx on lines 280..284
                source/web/main.jsx on lines 286..290

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 104.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                                <ReactRouter.Route path="presets" component={Presets}>
                    <ReactRouter.Route path="load" component={PresetsLoad}/>
                    <ReactRouter.Route path="view" component={PresetsView}/>
                    <ReactRouter.Route path="edit" component={PresetsEdit}/>
                </ReactRouter.Route>
                Severity: Major
                Found in source/web/main.jsx and 2 other locations - About 3 hrs to fix
                source/web/main.jsx on lines 286..290
                source/web/main.jsx on lines 291..295

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 104.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                                <ReactRouter.Route path="extensions" component={Extensions}>
                    <ReactRouter.Route path="chatwheels" component={ExtensionsChatwheels}/>
                    <ReactRouter.Route path="cycles" component={ExtensionsCycles}/>
                    <ReactRouter.Route path="layouts" component={ExtensionsLayouts}/>
                </ReactRouter.Route>
                Severity: Major
                Found in source/web/main.jsx and 2 other locations - About 3 hrs to fix
                source/web/main.jsx on lines 280..284
                source/web/main.jsx on lines 291..295

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 104.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status