Sign upLogin

dodekeract/manta-config-engine-app

View on GitHub
Star
source/web/store.js

Summary

Maintainability
D
2 days
Test Coverage

File store.js has 315 lines of code (exceeds 250 allowed). Consider refactoring.
Open

var assign       = require('object-assign');
var EventEmitter = require('events').EventEmitter;
var JSZip        = require('jszip');
var manta        = require('dota2-manta-config-engine');
var platform     = require('platform');
Severity: Minor
Found in source/web/store.js - About 3 hrs to fix

    Function purge has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        purge: function () {
        _state = {
            currentLayout: 0,
            changer: {
                key: '',
    Severity: Minor
    Found in source/web/store.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  if (action.slot < _state.preset.cycles[action.id].length - 1) {
                var swap = _state.preset.cycles[action.id][action.slot + 1];
                _state.preset.cycles[action.id][action.slot + 1] = _state.preset.cycles[action.id][action.slot];
                _state.preset.cycles[action.id][action.slot] = swap;
            }
      Severity: Major
      Found in source/web/store.js and 1 other location - About 4 hrs to fix
      source/web/store.js on lines 242..246

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 129.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  if (action.slot) {
                var swap = _state.preset.cycles[action.id][action.slot - 1];
                _state.preset.cycles[action.id][action.slot - 1] = _state.preset.cycles[action.id][action.slot];
                _state.preset.cycles[action.id][action.slot] = swap;
            }
      Severity: Major
      Found in source/web/store.js and 1 other location - About 4 hrs to fix
      source/web/store.js on lines 251..255

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 129.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              case constants.LOAD_CHATWHEEL:
            $.getJSON('chatwheels/' + action.id + '.json', function (data) {
                _state.preset.chatwheels.push(data.phrases);
                location.href = '#/chatwheels';
                store.emitChange();
      Severity: Major
      Found in source/web/store.js and 1 other location - About 2 hrs to fix
      source/web/store.js on lines 89..95

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 76.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              case constants.LOAD_CYCLE:
            $.getJSON('cycles/' + action.id + '.json', function (data) {
                _state.preset.cycles.push(data.actions);
                location.href = '#/cycles';
                store.emitChange();
      Severity: Major
      Found in source/web/store.js and 1 other location - About 2 hrs to fix
      source/web/store.js on lines 97..103

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 76.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              case constants.CYCLE_ADD_ITEM:
            _state.changer = {mode: 'cycle', data: [], key: action.id, view: -1};
            store.emitChange();
            $('#bind-changer').modal('show');
        break;
      Severity: Major
      Found in source/web/store.js and 1 other location - About 1 hr to fix
      source/web/store.js on lines 123..127

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              case constants.KEYBINDING_CHANGER_OPEN:
            _state.changer = {mode: 'bind', data: [], key: action.id, view: -1};
            store.emitChange();
            $('#bind-changer').modal('show');
        break;
      Severity: Major
      Found in source/web/store.js and 1 other location - About 1 hr to fix
      source/web/store.js on lines 259..263

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status