dougfales/gpx

View on GitHub

Showing 21 of 21 total issues

Method generate_xml_doc has a Cognitive Complexity of 71 (exceeds 5 allowed). Consider refactoring.
Open

    def generate_xml_doc
      @version ||= '1.1'
      version_dir = version.tr('.', '/')

      gpx_header = attributes_and_nsdefs_as_gpx_attributes
Severity: Minor
Found in lib/gpx/gpx_file.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

    def initialize(opts = {})
      super()
      @duration = 0
      @attributes = {}
      @namespace_defs = []
Severity: Minor
Found in lib/gpx/gpx_file.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method append_point has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    def append_point(pt)
      last_pt = @points[-1]
      if pt.time
        @earliest_point = pt if @earliest_point.nil? || (@earliest_point.time && pt.time < @earliest_point.time)
        @latest_point = pt if @latest_point.nil? || (@latest_point.time && pt.time > @latest_point.time)
Severity: Minor
Found in lib/gpx/segment.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has 70 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def initialize(opts = {})
      super()
      @duration = 0
      @attributes = {}
      @namespace_defs = []
Severity: Major
Found in lib/gpx/gpx_file.rb - About 2 hrs to fix

    Method generate_xml_doc has 67 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def generate_xml_doc
          @version ||= '1.1'
          version_dir = version.tr('.', '/')
    
          gpx_header = attributes_and_nsdefs_as_gpx_attributes
    Severity: Major
    Found in lib/gpx/gpx_file.rb - About 2 hrs to fix

      Method add has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

          def add(item)
            if item.respond_to?(:lat) && item.respond_to?(:lon)
              @min_lat = item.lat if item.lat < @min_lat
              @min_lon = item.lon if item.lon < @min_lon
              @max_lat = item.lat if item.lat > @max_lat
      Severity: Minor
      Found in lib/gpx/bounds.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File gpx_file.rb has 267 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      module GPX
        class GPXFile < Base
          attr_accessor :tracks,
                        :routes, :waypoints, :bounds, :lowest_point, :highest_point, :duration, :ns, :time, :name, :version, :creator, :description, :moving_duration
      
      
      Severity: Minor
      Found in lib/gpx/gpx_file.rb - About 2 hrs to fix

        Method update_meta_data has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

            def update_meta_data(pt, last_pt)
              if pt.time
                @earliest_point = pt if @earliest_point.nil? || (pt.time < @earliest_point.time)
                @latest_point = pt if @latest_point.nil? || (pt.time > @latest_point.time)
              else
        Severity: Minor
        Found in lib/gpx/segment.rb - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method initialize has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            def initialize(opts = { lat: 0.0, lon: 0.0, elevation: 0.0, time: Time.now })
              super()
              @gpx_file = opts[:gpx_file]
              if opts[:element]
                elem = opts[:element]
        Severity: Minor
        Found in lib/gpx/point.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method find_closest has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            def find_closest(pts, time)
              return pts.first if pts.size == 1
        
              midpoint = pts.size / 2
              if pts.size == 2
        Severity: Minor
        Found in lib/gpx/segment.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method smooth_location_by_average has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def smooth_location_by_average(opts = {})
              seconds_either_side = opts[:averaging_window] || 20
        
              # calculate the first and last points to which the smoothing should be applied
              earliest = (find_point_by_time_or_offset(opts[:start]) || @earliest_point).time
        Severity: Minor
        Found in lib/gpx/segment.rb - About 1 hr to fix

          Method convert_to_gpx has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                def convert_to_gpx(magellan_filename, gpx_filename)
                  segment = Segment.new
          
                  CSV.open(magellan_filename, 'r').each do |row|
                    next if (row.size < 10) || (row[INVALID_FLAG] == 'V')
          Severity: Minor
          Found in lib/gpx/magellan_track_log.rb - About 1 hr to fix

            Method initialize has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                def initialize(opts = {})
                  super()
                  @gpx_file = opts[:gpx_file]
                  @segments = []
                  @points = []
            Severity: Minor
            Found in lib/gpx/track.rb - About 1 hr to fix

              Method convert_to_gpx has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                    def convert_to_gpx(magellan_filename, gpx_filename)
                      segment = Segment.new
              
                      CSV.open(magellan_filename, 'r').each do |row|
                        next if (row.size < 10) || (row[INVALID_FLAG] == 'V')
              Severity: Minor
              Found in lib/gpx/magellan_track_log.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method magellan_file? has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                    def magellan_file?(filename)
                      i = 0
                      File.open(filename, 'r') do |f|
                        f.each do |line|
                          i += 1
              Severity: Minor
              Found in lib/gpx/magellan_track_log.rb - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  def crop(area)
                    reset_meta_data
                    keep_tracks = []
                    tracks.each do |trk|
                      trk.crop(area)
              Severity: Minor
              Found in lib/gpx/gpx_file.rb and 1 other location - About 40 mins to fix
              lib/gpx/gpx_file.rb on lines 172..184

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 38.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  def delete_area(area)
                    reset_meta_data
                    keep_tracks = []
                    tracks.each do |trk|
                      trk.delete_area(area)
              Severity: Minor
              Found in lib/gpx/gpx_file.rb and 1 other location - About 40 mins to fix
              lib/gpx/gpx_file.rb on lines 150..162

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 38.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Method update_meta_data has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  def update_meta_data(trk, get_bounds = true)
                    @lowest_point = trk.lowest_point if @lowest_point.nil? || (!trk.lowest_point.nil? && (trk.lowest_point.elevation < @lowest_point.elevation))
                    @highest_point = trk.highest_point if @highest_point.nil? || (!trk.highest_point.nil? && (trk.highest_point.elevation > @highest_point.elevation))
                    @bounds.add(trk.bounds) if get_bounds
                    @distance += trk.distance
              Severity: Minor
              Found in lib/gpx/gpx_file.rb - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      @min_lat = item.lat if item.lat < @min_lat
                      @min_lon = item.lon if item.lon < @min_lon
                      @max_lat = item.lat if item.lat > @max_lat
                      @max_lon = item.lon if item.lon > @max_lon
              Severity: Minor
              Found in lib/gpx/bounds.rb and 1 other location - About 30 mins to fix
              lib/gpx/bounds.rb on lines 44..47

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 33.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      @min_lat = item.min_lat if item.min_lat < @min_lat
                      @min_lon = item.min_lon if item.min_lon < @min_lon
                      @max_lat = item.max_lat if item.max_lat > @max_lat
                      @max_lon = item.max_lon if item.max_lon > @max_lon
              Severity: Minor
              Found in lib/gpx/bounds.rb and 1 other location - About 30 mins to fix
              lib/gpx/bounds.rb on lines 39..42

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 33.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Severity
              Category
              Status
              Source
              Language