drhenner/ror_ecommerce

View on GitHub
app/assets/javascripts/foundation/foundation.topbar.js

Summary

Maintainability
F
3 days
Test Coverage

Function events has 114 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    events : function () {
      var self = this;
      $(this.scope)
        .off('.fndtn.topbar')
        .on('click.fndtn.topbar', '.top-bar .toggle-topbar, [data-topbar] .toggle-topbar', function (e) {
Severity: Major
Found in app/assets/javascripts/foundation/foundation.topbar.js - About 4 hrs to fix

    File foundation.topbar.js has 292 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*jslint unparam: true, browser: true, indent: 2 */
    
    ;(function ($, window, document, undefined) {
      'use strict';
    
    
    Severity: Minor
    Found in app/assets/javascripts/foundation/foundation.topbar.js - About 3 hrs to fix

      Function toggle has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          toggle: function() {
            var self = this;
            var topbar = $('.top-bar, [data-topbar]'),
                section = topbar.find('section, .section');
      
      
      Severity: Minor
      Found in app/assets/javascripts/foundation/foundation.topbar.js - About 2 hrs to fix

        Function init has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            init : function (section, method, options) {
              Foundation.inherit(this, 'data_options addCustomRule');
              var self = this;
        
              if (typeof method === 'object') {
        Severity: Minor
        Found in app/assets/javascripts/foundation/foundation.topbar.js - About 1 hr to fix

          Avoid deeply nested control flow statements.
          Open

                      if ($(klass).hasClass('fixed')) {
                        $(klass).removeClass('fixed');
                        $('body').removeClass('f-topbar-fixed');
                      }
          Severity: Major
          Found in app/assets/javascripts/foundation/foundation.topbar.js - About 45 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        if (!self.rtl) {
                          section.css({left: -(100 * topbar.data('index')) + '%'});
                          section.find('>.name').css({left: 100 * topbar.data('index') + '%'});
                        } else {
                          section.css({right: -(100 * topbar.data('index')) + '%'});
            Severity: Major
            Found in app/assets/javascripts/foundation/foundation.topbar.js and 1 other location - About 6 hrs to fix
            app/assets/javascripts/foundation/foundation.topbar.js on lines 267..273

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 169.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (!self.rtl) {
                      section.css({left: -(100 * topbar.data('index')) + '%'});
                      section.find('>.name').css({left: 100 * topbar.data('index') + '%'});
                    } else {
                      section.css({right: -(100 * topbar.data('index')) + '%'});
            Severity: Major
            Found in app/assets/javascripts/foundation/foundation.topbar.js and 1 other location - About 6 hrs to fix
            app/assets/javascripts/foundation/foundation.topbar.js on lines 196..202

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 169.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                  if (typeof method === 'object') {
                    $.extend(true, this.settings, method);
                  } else if (typeof options !== 'undefined') {
                    $.extend(true, this.settings, options);
                  }
            Severity: Major
            Found in app/assets/javascripts/foundation/foundation.topbar.js and 2 other locations - About 1 hr to fix
            app/assets/javascripts/foundation/foundation.reveal.js on lines 42..46
            app/assets/javascripts/foundation/foundation.tooltips.js on lines 31..35

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 61.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    } else {
                      section.css({right: '0%'});
                      section.find('>.name').css({right: '100%'});
                    }
            Severity: Minor
            Found in app/assets/javascripts/foundation/foundation.topbar.js and 1 other location - About 30 mins to fix
            app/assets/javascripts/foundation/foundation.topbar.js on lines 85..88

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (!self.rtl) {
                      section.css({left: '0%'});
                      section.find('>.name').css({left: '100%'});
                    } else {
            Severity: Minor
            Found in app/assets/javascripts/foundation/foundation.topbar.js and 1 other location - About 30 mins to fix
            app/assets/javascripts/foundation/foundation.topbar.js on lines 88..91

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status