drhenner/ror_ecommerce

Function ajaxSubmit has 244 lines of code (exceeds 25 allowed). Consider refactoring.

Open

$.fn.ajaxSubmit = function(options) {
    // fast fail if nothing selected (http://dev.jquery.com/ticket/2752)
    if (!this.length) {
        log('ajaxSubmit: skipping submit process - no element selected');
        return this;

Function fileUpload has 156 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    function fileUpload() {
        var form = $form[0];

        if ($(':input[name=submit]', form).length) {
            alert('Error: Form elements must not be named "submit".');

File jquery.form.js has 424 lines of code (exceeds 250 allowed). Consider refactoring.

Open

/*!
 * jQuery Form Plugin
 * version: 2.43 (12-MAR-2010)
 * @requires jQuery v1.3.2 or later
 *

Consider simplifying this complex logical expression.

Open

    if (successful && (!n || el.disabled || t == 'reset' || t == 'button' ||
        (t == 'checkbox' || t == 'radio') && !el.checked ||
        (t == 'submit' || t == 'image') && el.form && el.form.clk != el ||
        tag == 'select' && el.selectedIndex == -1))
            return null;

Function cb has 59 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        function cb() {
            if (cbInvoked) 
                return;

            var ok = true;

Function formToArray has 32 lines of code (exceeds 25 allowed). Consider refactoring.

Open

$.fn.formToArray = function(semantic) {
    var a = [];
    if (this.length == 0) return a;

    var form = this[0];

Function doSubmit has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        function doSubmit() {
            // make sure form attrs are set
            var t = $form.attr('target'), a = $form.attr('action');

            // update form attrs in IE friendly way

Function ajaxForm has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

$.fn.ajaxForm = function(options) {
    return this.ajaxFormUnbind().bind('submit.form-plugin', function(e) {
        e.preventDefault();
        $(this).ajaxSubmit(options);
    }).bind('click.form-plugin', function(e) {

Function fieldValue has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

$.fieldValue = function(el, successful) {
    var n = el.name, t = el.type, tag = el.tagName.toLowerCase();
    if (typeof successful == 'undefined') successful = true;

    if (successful && (!n || el.disabled || t == 'reset' || t == 'button' ||

Avoid too many return statements within this function.

Open

    return this;

Avoid too many return statements within this function.

Open

        return this;

Avoid too many return statements within this function.

Open

    return el.value;

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if (v && v.constructor == Array) {
            for(var j=0, jmax=v.length; j < jmax; j++)
                a.push({name: n, value: v[j]});
        }
        else if (v !== null && typeof v != 'undefined')

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if (v && v.constructor == Array) {
            for (var i=0,max=v.length; i < max; i++)
                a.push({name: n, value: v[i]});
        }
        else if (v !== null && typeof v != 'undefined')

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            a.push({name: n+'.x', value: form.clk_x}, {name: n+'.y', value: form.clk_y});

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

                a.push({name: n+'.x', value: form.clk_x}, {name: n+'.y', value: form.clk_y});

• Read up
  Read up