drhenner/ror_ecommerce

View on GitHub
app/models/user.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Class User has 27 methods (exceeds 20 allowed). Consider refactoring.
Open

class User < ApplicationRecord
  include AASM
  include TransactionAccountable
  include UserCim
  include Presentation::UserPresenter
Severity: Minor
Found in app/models/user.rb - About 3 hrs to fix

    Method sanitize_data has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def sanitize_data
        self.email      = self.email.strip.downcase         unless email.blank?
        self.first_name = self.first_name.strip.capitalize  unless first_name.nil?
        self.last_name  = self.last_name.strip.capitalize   unless last_name.nil?
    
    
    Severity: Minor
    Found in app/models/user.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status