dry-rb/dry-monads

View on GitHub
lib/dry/monads/list.rb

Summary

Maintainability
B
5 hrs
Test Coverage
A
98%

Class List has 31 methods (exceeds 20 allowed). Consider refactoring.
Open

    class List
      class << self
        # Builds a list.
        #
        # @param values [Array<Object>] List elements
Severity: Minor
Found in lib/dry/monads/list.rb - About 3 hrs to fix

    Perceived complexity for coerce is too high. [8/7]
    Open

            def coerce(value, type = nil)
              if value.nil?
                List.new([], type)
              elsif value.respond_to?(:to_ary)
                values = value.to_ary
    Severity: Minor
    Found in lib/dry/monads/list.rb by rubocop

    This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

    Example:

    def my_method                   # 1
      if cond                       # 1
        case var                    # 2 (0.8 + 4 * 0.2, rounded)
        when 1 then func_one
        when 2 then func_two
        when 3 then func_three
        when 4..10 then func_other
        end
      else                          # 1
        do_something until a && b   # 2
      end                           # ===
    end                             # 7 complexity points

    Method collect has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

          def collect
            if block_given?
              collected = value.each_with_object([]) do |x, ys|
                y = yield(x)
                ys << y.value! if y.some?
    Severity: Minor
    Found in lib/dry/monads/list.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method coerce has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

            def coerce(value, type = nil)
              if value.nil?
                List.new([], type)
              elsif value.respond_to?(:to_ary)
                values = value.to_ary
    Severity: Minor
    Found in lib/dry/monads/list.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Use a guard clause instead of wrapping the code inside a conditional expression.
    Open

              if size.zero?
    Severity: Minor
    Found in lib/dry/monads/list.rb by rubocop

    Use a guard clause instead of wrapping the code inside a conditional expression

    Example:

    # bad
    def test
      if something
        work
      end
    end
    
    # good
    def test
      return unless something
      work
    end
    
    # also good
    def test
      work if something
    end
    
    # bad
    if something
      raise 'exception'
    else
      ok
    end
    
    # good
    raise 'exception' if something
    ok

    Use a guard clause instead of wrapping the code inside a conditional expression.
    Open

                if m.some?
    Severity: Minor
    Found in lib/dry/monads/list.rb by rubocop

    Use a guard clause instead of wrapping the code inside a conditional expression

    Example:

    # bad
    def test
      if something
        work
      end
    end
    
    # good
    def test
      return unless something
      work
    end
    
    # also good
    def test
      work if something
    end
    
    # bad
    if something
      raise 'exception'
    else
      ok
    end
    
    # good
    raise 'exception' if something
    ok

    There are no issues that match your filters.

    Category
    Status