Sign upLogin

dwhswenson/contact_map

View on GitHub
Star

Showing 3 of 68 total issues

File contact_map.py has 786 lines of code (exceeds 750 allowed). Consider refactoring.
Confirmed

"""
Contact map analysis.
"""
# Maintainer: David W.H. Swenson (dwhs@hyperblazer.net)
# Licensed under LGPL, version 2.1 or greater
Severity: Major
Found in contact_map/contact_map.py - About 2 hrs to fix

    Function to_networkx has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def to_networkx(self, weighted=True, as_index=False, graph=None):
        """Graph representation of contacts (requires networkx)

        Parameters
        ----------
    Severity: Minor
    Found in contact_map/contact_count.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _sanitize_n_x_n_y has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    def _sanitize_n_x_n_y(n_x, n_y, counter):
    if n_x is None and n_y is None:
        n_x, n_y = _get_sorted_counter_range(counter)
    elif n_x is None or n_y is None:
        raise ValueError("Either both n_x and n_y need to be defined or "
    Severity: Minor
    Found in contact_map/plot_utils.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language