dysania/onebox

View on GitHub
lib/onebox/engine/allowlisted_generic_onebox.rb

Summary

Maintainability
D
2 days
Test Coverage

Method default_allowed_domains has 116 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def self.default_allowed_domains
        %w(
          23hq.com
          500px.com
          8tracks.com
Severity: Major
Found in lib/onebox/engine/allowlisted_generic_onebox.rb - About 4 hrs to fix

    Class AllowlistedGenericOnebox has 32 methods (exceeds 20 allowed). Consider refactoring.
    Open

        class AllowlistedGenericOnebox
          include Engine
          include StandardEmbed
          include LayoutSupport
    
    
    Severity: Minor
    Found in lib/onebox/engine/allowlisted_generic_onebox.rb - About 4 hrs to fix

      File allowlisted_generic_onebox.rb has 326 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      require 'htmlentities'
      
      module Onebox
        module Engine
          class AllowlistedGenericOnebox
      Severity: Minor
      Found in lib/onebox/engine/allowlisted_generic_onebox.rb - About 3 hrs to fix

        Method data has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def data
                @data ||= begin
                  html_entities = HTMLEntities.new
                  d = { link: link }.merge(raw)
        
        
        Severity: Minor
        Found in lib/onebox/engine/allowlisted_generic_onebox.rb - About 1 hr to fix

          Avoid too many return statements within this method.
          Open

                  return article_html  if has_text?
          Severity: Major
          Found in lib/onebox/engine/allowlisted_generic_onebox.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return card_html     if is_card?
            Severity: Major
            Found in lib/onebox/engine/allowlisted_generic_onebox.rb - About 30 mins to fix

              Method generic_html has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                    def generic_html
                      return article_html  if is_article?
                      return video_html    if is_video?
                      return image_html    if is_image?
                      return embedded_html if is_embedded?
              Severity: Minor
              Found in lib/onebox/engine/allowlisted_generic_onebox.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method is_embedded? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                    def is_embedded?
                      return false unless data[:html] && data[:height]
                      return true if AllowlistedGenericOnebox.html_providers.include?(data[:provider_name])
                      return false unless data[:html]["iframe"]
              
              
              Severity: Minor
              Found in lib/onebox/engine/allowlisted_generic_onebox.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                        if !Onebox::Helpers.blank?(d[:label1]) && !Onebox::Helpers.blank?(d[:data1]) && !!AllowlistedGenericOnebox.allowed_twitter_labels.find { |l| d[:label1] =~ /#{l}/i }
                          d[:label_1] = Onebox::Helpers.truncate(d[:label1])
                          d[:data_1]  = Onebox::Helpers.truncate(d[:data1])
                        end
              Severity: Minor
              Found in lib/onebox/engine/allowlisted_generic_onebox.rb and 1 other location - About 25 mins to fix
              lib/onebox/engine/allowlisted_generic_onebox.rb on lines 244..252

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 30.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                        if !Onebox::Helpers.blank?(d[:label2]) && !Onebox::Helpers.blank?(d[:data2]) && !!AllowlistedGenericOnebox.allowed_twitter_labels.find { |l| d[:label2] =~ /#{l}/i }
                          unless Onebox::Helpers.blank?(d[:label_1])
                            d[:label_2] = Onebox::Helpers.truncate(d[:label2])
                            d[:data_2]  = Onebox::Helpers.truncate(d[:data2])
                          else
              Severity: Minor
              Found in lib/onebox/engine/allowlisted_generic_onebox.rb and 1 other location - About 25 mins to fix
              lib/onebox/engine/allowlisted_generic_onebox.rb on lines 240..243

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 30.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status