dysania/onebox

View on GitHub
lib/onebox/engine/amazon_onebox.rb

Summary

Maintainability
D
1 day
Test Coverage

Method data has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

      def data
        og = ::Onebox::OpenGraph.new(raw)

        if raw.at_css('#dp.book_mobile') #printed books
          title = raw.at("h1#title")&.inner_text
Severity: Minor
Found in lib/onebox/engine/amazon_onebox.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method data has 67 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def data
        og = ::Onebox::OpenGraph.new(raw)

        if raw.at_css('#dp.book_mobile') #printed books
          title = raw.at("h1#title")&.inner_text
Severity: Major
Found in lib/onebox/engine/amazon_onebox.rb - About 2 hrs to fix

    Consider simplifying this complex logical expression.
    Open

            elsif raw.at_css('#dp.ebooks_mobile') # ebooks
              title = raw.at("#ebooksTitle")&.inner_text
              authors = raw.at_css('#a-popover-mobile-udp-contributor-popover-id') ? multiple_authors("//div[@id='a-popover-mobile-udp-contributor-popover-id']//span[contains(@class,'a-text-bold')]") : (raw.at("#byline")&.inner_text&.strip || raw.at("#bylineInfo")&.inner_text&.strip)
              rating = raw.at("#averageCustomerReviews_feature_div .a-icon")&.inner_text || raw.at("#cmrsArcLink .a-icon")&.inner_text || raw.at("#acrCustomerReviewLink .a-icon")&.inner_text
    
    
    Severity: Critical
    Found in lib/onebox/engine/amazon_onebox.rb - About 1 hr to fix

      Method image has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def image
              if (main_image = raw.css("#main-image")) && main_image.any?
                attributes = main_image.first.attributes
      
                return attributes["data-a-hires"].to_s if attributes["data-a-hires"]
      Severity: Minor
      Found in lib/onebox/engine/amazon_onebox.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                result = {
                  link: link,
                  title: title,
                  by_info: authors,
                  image: og.image || image,
      Severity: Major
      Found in lib/onebox/engine/amazon_onebox.rb and 1 other location - About 1 hr to fix
      lib/onebox/engine/amazon_onebox.rb on lines 133..145

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 54.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                result = {
                  link: link,
                  title: title,
                  by_info: authors,
                  image: og.image || image,
      Severity: Major
      Found in lib/onebox/engine/amazon_onebox.rb and 1 other location - About 1 hr to fix
      lib/onebox/engine/amazon_onebox.rb on lines 102..114

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 54.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status