Sign upLogin

ece517-p3/expertiza

View on GitHub
Star
spec/models/simi_check_webservice_spec.rb

Summary

Maintainability
A
25 mins
Test Coverage

Block has too many lines. [182/25]
Open

xdescribe "SimiCheckWebservice" do
  def poll(comp_id)
    is_success = false
    until is_success
      begin
Severity: Minor
Found in spec/models/simi_check_webservice_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Method poll has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def poll(comp_id)
    is_success = false
    until is_success
      begin
        response = SimiCheckWebService.get_similarity_nxn(comp_id)
Severity: Minor
Found in spec/models/simi_check_webservice_spec.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status