edgewall/trac

View on GitHub

Showing 1,372 of 1,372 total issues

Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(self, default_data=False, enable=None, disable=None,
Severity: Minor
Found in trac/test.py - About 45 mins to fix

    Function to_sql has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def to_sql(self, table, max_bytes=None):
            if max_bytes is None:
                max_bytes = self._max_bytes(None)
            sql = ['CREATE TABLE %s (' % _quote(table.name)]
            coldefs = []
    Severity: Minor
    Found in trac/db/mysql_backend.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _collist has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def _collist(self, table, columns, max_bytes):
            """Take a list of columns and impose limits on each so that indexing
            works properly.
    
            Some Versions of MySQL limit each index prefix to 3072 bytes total,
    Severity: Minor
    Found in trac/db/mysql_backend.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function backup has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def backup(self, dest_file):
            db_url = self.env.config.get('trac', 'database')
            scheme, db_prop = parse_connection_uri(db_url)
            db_params = db_prop.setdefault('params', {})
            db_params.setdefault('schema', 'public')
    Severity: Minor
    Found in trac/db/postgres_backend.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function copy_tables has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def copy_tables(src_env, dst_env, src_db, dst_db, src_dburi, dst_dburi):
    Severity: Minor
    Found in trac/db/convert.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                              if isinstance(option, Option):
                                  set_option_default(option)
              else:
      Severity: Major
      Found in trac/config.py - About 45 mins to fix

        Function find_by_sid_class_realm_and_target has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def find_by_sid_class_realm_and_target(cls, env, sid, authenticated,
        Severity: Minor
        Found in trac/notification/model.py - About 45 mins to fix

          Function _get_registry has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          def _get_registry(cls, compmgr=None):
              """Return the descriptor registry.
          
              If `compmgr` is specified, only return descriptors for components that
              are enabled in the given `ComponentManager`.
          Severity: Minor
          Found in trac/config.py - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def __init__(self, section, name, default=None, doc='',
          Severity: Minor
          Found in trac/config.py - About 45 mins to fix

            Function get_configinfo has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

            def get_configinfo(env):
                """Returns a list of dictionaries containing the `name` and `options`
                of each configuration section. The value of `options` is a list of
                dictionaries containing the `name`, `value` and `modified` state of
                each configuration option. The `modified` value is True if the value
            Severity: Minor
            Found in trac/config.py - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function __new__ has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                def __new__(mcs, name, bases, d):
                    """Create the component class."""
            
                    new_class = type.__new__(mcs, name, bases, d)
                    if name == 'Component':
            Severity: Minor
            Found in trac/core.py - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid deeply nested control flow statements.
            Open

                                        if f['filename'].endswith(nsrc):
                                            plugin['frame_idx'] = i
                                            return
                        except KeyError:
            Severity: Major
            Found in trac/loader.py - About 45 mins to fix

              Function shutdown has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  def shutdown(self, tid=None):
                      """Close pooled connections not used in a while"""
                      delay = 120
                      if tid is None:
                          delay = 0
              Severity: Minor
              Found in trac/db/pool.py - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid deeply nested control flow statements.
              Open

                                      if 'meta' in base and i in base['meta']:
                                          f[i] = Markup('<em>%s</em>') % f[i]
                                  for i in range(len(t)):
              Severity: Major
              Found in trac/mimeview/patch.py - About 45 mins to fix

                Function add_meta has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                def add_meta(req, content, http_equiv=None, name=None, scheme=None, lang=None):
                Severity: Minor
                Found in trac/web/chrome.py - About 45 mins to fix

                  Function run has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def run(self):
                          """Begin processing data from the socket."""
                          self._keepGoing = True
                          while self._keepGoing:
                              try:
                  Severity: Minor
                  Found in trac/web/_fcgi.py - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function _get_list has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def _get_list(self, sids):
                          all_anon = 'anonymous' in sids or '*' in sids
                          all_auth = 'authenticated' in sids or '*' in sids
                          sids = {self._split_sid(sid)
                                  for sid in sids
                  Severity: Minor
                  Found in trac/web/session.py - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function get_supported_conversions has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def get_supported_conversions(self, mimetype):
                          """Return a list of target MIME types as instances of the `namedtuple`
                          `MimeConversion`. Output is ordered from best to worst quality.
                  
                          The `MimeConversion` `namedtuple` has fields: key, name, extension,
                  Severity: Minor
                  Found in trac/mimeview/api.py - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Avoid deeply nested control flow statements.
                  Open

                                          if 'meta' in changed and i in changed['meta']:
                                              t[i] = Markup('<em>%s</em>') % t[i]
                          return changes
                  Severity: Major
                  Found in trac/mimeview/patch.py - About 45 mins to fix

                    Function get_change has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def get_change(self, cnum=None, cdate=None):
                            """Return a ticket change by its number or date.
                            """
                            if cdate is None:
                                row = self._find_change(cnum)
                    Severity: Minor
                    Found in trac/ticket/model.py - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language