Sign upLogin

efritz/ij

View on GitHub
Star
loader/jsonconfig/push_task.go

Summary

Maintainability
A
2 hrs
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package jsonconfig

import (
    "encoding/json"
Severity: Major
Found in loader/jsonconfig/push_task.go and 1 other location - About 2 hrs to fix
loader/jsonconfig/remove_task.go on lines 1..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 242.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

exported type PushTask should have comment or be unexported
Open

type PushTask struct {
Severity: Minor
Found in loader/jsonconfig/push_task.go by golint

exported method PushTask.Translate should have comment or be unexported
Open

func (t *PushTask) Translate(name string) (config.Task, error) {
Severity: Minor
Found in loader/jsonconfig/push_task.go by golint

There are no issues that match your filters.

Category
Status