paths/transferer.go

Summary

Maintainability
A
2 hrs
Test Coverage

Method Transferer.transferPath has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    rawSrc string,
    rawDest string,
    srcRoot string,
    destRoot string,
    blacklist map[string]struct{},
Severity: Minor
Found in paths/transferer.go - About 35 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func (t *Transferer) Import(patterns, blacklistPatterns []string) error {
        blacklist, err := constructBlacklist(t.project, blacklistPatterns)
        if err != nil {
            return err
        }
    Severity: Major
    Found in paths/transferer.go and 1 other location - About 1 hr to fix
    paths/transferer.go on lines 49..58

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 131.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func (t *Transferer) Export(patterns, blacklistPatterns []string) error {
        blacklist, err := constructBlacklist(t.workspace, blacklistPatterns)
        if err != nil {
            return err
        }
    Severity: Major
    Found in paths/transferer.go and 1 other location - About 1 hr to fix
    paths/transferer.go on lines 38..47

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 131.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    exported type Transferer should have comment or be unexported
    Open

    type Transferer struct {
    Severity: Minor
    Found in paths/transferer.go by golint

    exported var DefaultBlacklist should have comment or be unexported
    Open

    var DefaultBlacklist = []string{
    Severity: Minor
    Found in paths/transferer.go by golint

    exported function NewTransferer should have comment or be unexported
    Open

    func NewTransferer(
    Severity: Minor
    Found in paths/transferer.go by golint

    exported method Transferer.Export should have comment or be unexported
    Open

    func (t *Transferer) Export(patterns, blacklistPatterns []string) error {
    Severity: Minor
    Found in paths/transferer.go by golint

    exported method Transferer.Import should have comment or be unexported
    Open

    func (t *Transferer) Import(patterns, blacklistPatterns []string) error {
    Severity: Minor
    Found in paths/transferer.go by golint

    There are no issues that match your filters.

    Category
    Status