runner/build_task.go

Summary

Maintainability
A
1 hr
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func (s *buildTaskCommandBuilderState) addTagOptions(cb *command.Builder) error {
    for _, tag := range s.task.Tags {
        expanded, err := s.env.ExpandString(tag)
        if err != nil {
            return err
Severity: Minor
Found in runner/build_task.go and 1 other location - About 30 mins to fix
runner/build_task.go on lines 136..147

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 102.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func (s *buildTaskCommandBuilderState) addLabelOptions(cb *command.Builder) error {
    for _, label := range s.task.Labels {
        expanded, err := s.env.ExpandString(label)
        if err != nil {
            return err
Severity: Minor
Found in runner/build_task.go and 1 other location - About 30 mins to fix
runner/build_task.go on lines 123..134

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 102.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

exported type BuildTaskRunnerFactory should have comment or be unexported
Open

    BuildTaskRunnerFactory func(
Severity: Minor
Found in runner/build_task.go by golint

exported function NewBuildTaskRunnerFactory should have comment or be unexported
Open

func NewBuildTaskRunnerFactory(
Severity: Minor
Found in runner/build_task.go by golint

There are no issues that match your filters.

Category
Status