Sign upLogin

efritz/ij

View on GitHub
Star
runner/stage.go

Summary

Maintainability
A
3 hrs
Test Coverage

Method StageRunner.buildTaskRunnerFunc has 69 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (r *StageRunner) buildTaskRunnerFunc(
    stageTask *config.StageTask,
    index int,
    task config.Task,
    context *RunContext,
Severity: Minor
Found in runner/stage.go - About 1 hr to fix

    Function NewStageRunner has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        ctx context.Context,
    logger logging.Logger,
    config *config.Config,
    taskRunnerFactory TaskRunnerFactory,
    plan *config.Plan,
    Severity: Major
    Found in runner/stage.go - About 1 hr to fix

      Method StageRunner.buildTaskRunnerFunc has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          stageTask *config.StageTask,
    index int,
    task config.Task,
    context *RunContext,
    ambiguous bool,
      Severity: Minor
      Found in runner/stage.go - About 35 mins to fix

        exported type TaskRunnerFunc should have comment or be unexported
        Open

            TaskRunnerFunc func() bool
        Severity: Minor
        Found in runner/stage.go by golint

        exported type StageRunner should have comment or be unexported
        Open

            StageRunner struct {
        Severity: Minor
        Found in runner/stage.go by golint

        exported function NewStageRunner should have comment or be unexported
        Open

        func NewStageRunner(
        Severity: Minor
        Found in runner/stage.go by golint

        exported method StageRunner.IsDisabled should have comment or be unexported
        Open

        func (r *StageRunner) IsDisabled(context *RunContext) (bool, error) {
        Severity: Minor
        Found in runner/stage.go by golint

        exported method StageRunner.Run should have comment or be unexported
        Open

        func (r *StageRunner) Run(context *RunContext) bool {
        Severity: Minor
        Found in runner/stage.go by golint

        There are no issues that match your filters.

        Category
        Status