Sign upLogin

elwayman02/ember-user-activity

View on GitHub
Star

Showing 4 of 4 total issues

Function _hasScrolled has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  _hasScrolled(now) {
    let { _subscribers: subscribers, _lastCheckAt: lastCheckAt } = this;
    let lowPriorityFrame = now - lastCheckAt < MAX_POLL_PERIOD;
    let hasScrolled = false;
    for (let i = 0; i < subscribers.length; i++) {
Severity: Minor
Found in addon/services/scroll-activity.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getScroll has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

export default function getScroll(elem, direction) {
  if (elem === null || elem === undefined) {
    return;
  }
Severity: Minor
Found in addon/utils/get-scroll.js - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

  return elem.scrollTop;
Severity: Major
Found in addon/utils/get-scroll.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return elem.scrollLeft;
    Severity: Major
    Found in addon/utils/get-scroll.js - About 30 mins to fix
      Severity
      Category
      Status
      Source
      Language