Sign upLogin

emory-libraries/dlp-selfdeposit

View on GitHub
Star

Showing 13 of 13 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

function dateIssuedValidation() {
    console.log("Date Issued Validation");

    var dateIssueValue = document.getElementById("publication_date_issued").value;
    var dateIssuedBool = isDateValid(dateIssueValue);
Severity: Major
Found in app/assets/javascripts/accordion.js and 2 other locations - About 5 hrs to fix
app/assets/javascripts/accordion.js on lines 346..368
app/assets/javascripts/accordion.js on lines 370..392

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 152.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

function finalPubVerValidation() {
    console.log("finalPubVer URL Validation");

    var finalPubVer = document.getElementById("publication_final_published_versions").value;
    var finalPubVerBool = isUrlValid(finalPubVer);
Severity: Major
Found in app/assets/javascripts/accordion.js and 2 other locations - About 5 hrs to fix
app/assets/javascripts/accordion.js on lines 306..327
app/assets/javascripts/accordion.js on lines 346..368

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 152.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

function relatedDataValidation() {
    console.log("relatedData URL Validation");

    var relatedData = document.getElementById("publication_related_datasets").value;
    var relatedDataBool = isUrlValid(relatedData);
Severity: Major
Found in app/assets/javascripts/accordion.js and 2 other locations - About 5 hrs to fix
app/assets/javascripts/accordion.js on lines 306..327
app/assets/javascripts/accordion.js on lines 370..392

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 152.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File works_controller_behavior.rb has 389 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'iiif_manifest'

module Hyrax
  module WorksControllerBehavior
    extend ActiveSupport::Concern
Severity: Minor
Found in app/controllers/concerns/hyrax/works_controller_behavior.rb - About 5 hrs to fix

    File accordion.js has 357 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    // TO DO: Remove console.log statements

// wait for page to load (ruby seems to act weird if we don't)
document.addEventListener('DOMContentLoaded', function (event) {
    // get accordion elements
    Severity: Minor
    Found in app/assets/javascripts/accordion.js - About 4 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              case 'Book Chapter': {
            resetForm();
            console.log('Selected: Book Chapter');

            confName[0].style.display = "none";
      Severity: Major
      Found in app/assets/javascripts/accordion.js and 1 other location - About 4 hrs to fix
      app/assets/javascripts/accordion.js on lines 81..91

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 125.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              case 'Article': {
            resetForm();
            console.log("Chose: Article");
            confName[0].style.display = "none";
            isbn[0].style.display = "none";
      Severity: Major
      Found in app/assets/javascripts/accordion.js and 1 other location - About 4 hrs to fix
      app/assets/javascripts/accordion.js on lines 108..120

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 125.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function formSetup has 99 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function formSetup() {
    //fields
    var parTitle = document.getElementsByClassName("form-group string optional publication_parent_title");
    var confName = document.getElementsByClassName("form-group string optional publication_conference_name");
    var isbn = document.getElementsByClassName("form-group string optional publication_isbn");
      Severity: Major
      Found in app/assets/javascripts/accordion.js - About 3 hrs to fix

        Function validateForm has 70 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function validateForm() {
        Severity: Major
        Found in app/assets/javascripts/accordion.js - About 2 hrs to fix

          Function validateForm has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

          function validateForm() {
          Severity: Minor
          Found in app/assets/javascripts/accordion.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method to_solr has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

                def to_solr
        super.tap do |solr_doc|
          solr_doc['alternate_ids_ssim'] = find_alternate_ids
          solr_doc['preservation_events_tesim'] = resource&.preservation_events&.map(&:preservation_event_terms)
          Severity: Minor
          Found in app/indexers/self_deposit/indexers/file_set_indexer.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this function.
          Open

                          return false;
          Severity: Major
          Found in app/assets/javascripts/accordion.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                            return true;
            Severity: Major
            Found in app/assets/javascripts/accordion.js - About 30 mins to fix
              Severity
              Category
              Status
              Source
              Language