emsa16/comment

View on GitHub

Showing 12 of 12 total issues

Method editComment has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function editComment($postid)
    {
        $actionID = (int)$this->di->request->getGet("id");
        $currentComment = $this->comments->findSoft('id', $actionID);
        if (!$currentComment) {
Severity: Minor
Found in src/Comment/CommentController.php - About 1 hr to fix

    Method replyComment has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function replyComment($postid)
        {
            $loggedInUser = $this->di->userController->getLoggedInUserId();
            if (is_null($loggedInUser)) {
                $this->di->response->redirect("comment/$postid");
    Severity: Minor
    Found in src/Comment/CommentController.php - About 1 hr to fix

      Method deleteComment has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function deleteComment($postid)
          {
              $actionID = (int)$this->di->request->getGet("id");
              $currentComment = $this->comments->findSoft('id', $actionID);
              if (!$currentComment) {
      Severity: Minor
      Found in src/Comment/CommentController.php - About 1 hr to fix

        Avoid variables with short names like $v. Configured minimum length is 3.
        Open

                foreach ($timeValues as $k => &$v) {
        Severity: Minor
        Found in src/Comment/Comment.php by phpmd

        ShortVariable

        Since: 0.2

        Detects when a field, local, or parameter has a very short name.

        Example

        class Something {
            private $q = 15; // VIOLATION - Field
            public static function main( array $as ) { // VIOLATION - Formal
                $r = 20 + $this->q; // VIOLATION - Local
                for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                    $r += $this->q;
                }
            }
        }

        Source https://phpmd.org/rules/naming.html#shortvariable

        Missing class import via use statement (line '58', column '20').
        Open

                $now = new \DateTime;
        Severity: Minor
        Found in src/Comment/Comment.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
            return new \stdClass();
        }

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '59', column '20').
        Open

                $ago = new \DateTime($datetime);
        Severity: Minor
        Found in src/Comment/Comment.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
            return new \stdClass();
        }

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Line exceeds 120 characters; contains 147 characters
        Open

                <?= $this->renderView('comment/form', ["method" => "", "submit" => "Skicka", "postid" => $postid, "form" => $newForm, "parent_id" => 0]) ?>
        Severity: Minor
        Found in view/comment-section.php by phpcodesniffer

        Line exceeds 120 characters; contains 174 characters
        Open

                    <?= $this->renderView('comment/form', ["method" => "edit?id={$comment->id}", "submit" => "Spara", "postid" => $postid, "comment" => $comment, "form" => $form]) ?>
        Severity: Minor
        Found in view/comment-tree.php by phpcodesniffer

        Line exceeds 120 characters; contains 182 characters
        Open

                    <?= $this->renderView('comment/form', ["method" => "reply?id={$comment->id}", "submit" => "Skicka", "postid" => $postid, "parent_id" => $comment->id, "form" => $form]) ?>
        Severity: Minor
        Found in view/comment-tree.php by phpcodesniffer

        Line exceeds 120 characters; contains 242 characters
        Open

                        <?= $this->renderView('comment/comment-tree', ["comments" => $comment->children, "textfilter" => $textfilter, "postid" => $postid, "action" => $action, "actionID" => $actionID, "form" => $form, "isLoggedIn" => $isLoggedIn]) ?>
        Severity: Minor
        Found in view/comment-tree.php by phpcodesniffer

        Line exceeds 120 characters; contains 221 characters
        Open

            <?= $this->renderView("comment/comment-tree", ["comments" => $comments, "textfilter" => $textfilter, "postid" => $postid, "action" => $action, "actionID" => $actionID, "form" => $form, "isLoggedIn" => $isLoggedIn]) ?>
        Severity: Minor
        Found in view/comment-section.php by phpcodesniffer

        Line exceeds 120 characters; contains 159 characters
        Open

                    <?= $points ?> poäng | av <?= !$comment->userObject->deleted ? $comment->userObject->username : '[raderad]' ?> | tillagd <?= $created . $edited ?>
        Severity: Minor
        Found in view/comment-tree.php by phpcodesniffer
        Severity
        Category
        Status
        Source
        Language