emsa16/comment

Method editComment has 32 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function editComment($postid)
    {
        $actionID = (int)$this->di->request->getGet("id");
        $currentComment = $this->comments->findSoft('id', $actionID);
        if (!$currentComment) {

Method replyComment has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function replyComment($postid)
    {
        $loggedInUser = $this->di->userController->getLoggedInUserId();
        if (is_null($loggedInUser)) {
            $this->di->response->redirect("comment/$postid");

Method deleteComment has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function deleteComment($postid)
    {
        $actionID = (int)$this->di->request->getGet("id");
        $currentComment = $this->comments->findSoft('id', $actionID);
        if (!$currentComment) {

Avoid variables with short names like $v. Configured minimum length is 3.

Open

        foreach ($timeValues as $k => &$v) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Missing class import via use statement (line '59', column '20').

Open

        $ago = new \DateTime($datetime);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '58', column '20').

Open

        $now = new \DateTime;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Line exceeds 120 characters; contains 174 characters

Open

            <?= $this->renderView('comment/form', ["method" => "edit?id={$comment->id}", "submit" => "Spara", "postid" => $postid, "comment" => $comment, "form" => $form]) ?>

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 147 characters

Open

        <?= $this->renderView('comment/form', ["method" => "", "submit" => "Skicka", "postid" => $postid, "form" => $newForm, "parent_id" => 0]) ?>

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 221 characters

Open

    <?= $this->renderView("comment/comment-tree", ["comments" => $comments, "textfilter" => $textfilter, "postid" => $postid, "action" => $action, "actionID" => $actionID, "form" => $form, "isLoggedIn" => $isLoggedIn]) ?>

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 159 characters

Open

            <?= $points ?> poäng | av <?= !$comment->userObject->deleted ? $comment->userObject->username : '[raderad]' ?> | tillagd <?= $created . $edited ?>

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 242 characters

Open

                <?= $this->renderView('comment/comment-tree', ["comments" => $comment->children, "textfilter" => $textfilter, "postid" => $postid, "action" => $action, "actionID" => $actionID, "form" => $form, "isLoggedIn" => $isLoggedIn]) ?>

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 182 characters

Open

            <?= $this->renderView('comment/form', ["method" => "reply?id={$comment->id}", "submit" => "Skicka", "postid" => $postid, "parent_id" => $comment->id, "form" => $form]) ?>

• Exclude checks
  • Disable engine
  • Disable check