envylabs/vaulted_billing

View on GitHub

Showing 18 of 24 total issues

File ipcommerce.rb has 385 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'multi_json'
require 'multi_xml'
require 'net/http'

module VaultedBilling
Severity: Minor
Found in lib/vaulted_billing/gateways/ipcommerce.rb - About 5 hrs to fix

    Class Ipcommerce has 28 methods (exceeds 20 allowed). Consider refactoring.
    Open

        class Ipcommerce
          include VaultedBilling::Gateway
          
          AvsResults = [
            "Not Set", "Not Included", "Match", "No Match", "Issuer Not Certified",
    Severity: Minor
    Found in lib/vaulted_billing/gateways/ipcommerce.rb - About 3 hrs to fix

      Method card_data has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

            def card_data(credit_card)
              return nil if credit_card.nil?
              { 
                'PaymentAccountDataToken' => credit_card.vault_id,
                'CardData' => { 
      Severity: Minor
      Found in lib/vaulted_billing/gateways/ipcommerce.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Class AuthorizeNetCim has 23 methods (exceeds 20 allowed). Consider refactoring.
      Open

          class AuthorizeNetCim
            include VaultedBilling::Gateway
            attr_accessor :use_test_uri
      
            def initialize(options = {})
      Severity: Minor
      Found in lib/vaulted_billing/gateways/authorize_net_cim.rb - About 2 hrs to fix

        File authorize_net_cim.rb has 264 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        require 'builder'
        require 'multi_xml'
        
        module VaultedBilling
          module Gateways
        Severity: Minor
        Found in lib/vaulted_billing/gateways/authorize_net_cim.rb - About 2 hrs to fix

          Class NmiCustomerVault has 21 methods (exceeds 20 allowed). Consider refactoring.
          Open

              class NmiCustomerVault
                include VaultedBilling::Gateway
                attr_accessor :use_test_uri
          
                def initialize(options = {})
          Severity: Minor
          Found in lib/vaulted_billing/gateways/nmi_customer_vault.rb - About 2 hrs to fix

            Method billing_info! has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
            Open

                  def billing_info!(xml, customer, credit_card)
                    xml.billTo do
                      xml.firstName credit_card.first_name if credit_card.first_name.present?
                      xml.lastName credit_card.last_name if credit_card.last_name.present?
                      xml.address credit_card.street_address if credit_card.street_address.present?
            Severity: Minor
            Found in lib/vaulted_billing/gateways/authorize_net_cim.rb - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method refund has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

                  def refund(transaction_id, amount, options = {})
                    data = build_request('createCustomerProfileTransactionRequest') { |xml|
                      xml.transaction do
                        xml.profileTransRefund do
                          xml.amount amount
            Severity: Minor
            Found in lib/vaulted_billing/gateways/authorize_net_cim.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method request has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                def request(method, uris, body = nil, options = {})
                  uri = uris.shift || raise(ArgumentError, "URI is empty")
            
                  request = case method
                  when :get
            Severity: Minor
            Found in lib/vaulted_billing/http.rb - About 1 hr to fix

              Method authorize has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                    def authorize(customer, credit_card, amount, options = {})
                      credit_card = credit_card.to_vaulted_billing
                      data = {
                        "__type" => "AuthorizeTransaction:http://schemas.ipcommerce.com/CWS/v2.0/Transactions/Rest",
                        :ApplicationProfileId => @application_id,
              Severity: Minor
              Found in lib/vaulted_billing/gateways/ipcommerce.rb - About 1 hr to fix

                Method purchase has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                      def purchase(customer, credit_card, amount, options = {})
                        credit_card = credit_card.try(:to_vaulted_billing)
                        data = {
                          "__type" => "AuthorizeAndCaptureTransaction:http://schemas.ipcommerce.com/CWS/v2.0/Transactions/Rest",
                          :ApplicationProfileId => @application_id,
                Severity: Minor
                Found in lib/vaulted_billing/gateways/ipcommerce.rb - About 1 hr to fix

                  Method new_transaction_from_response has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                        def new_transaction_from_response(response)
                          if response.success?
                            Transaction.new({
                              :id => response.body['TransactionId'],
                              :avs_response => parse_avs_result(response.body['AVSResult']),
                  Severity: Minor
                  Found in lib/vaulted_billing/gateways/ipcommerce.rb - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method credit_card_info! has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                        def credit_card_info!(xml, customer, credit_card)
                          xml.payment do
                            xml.creditCard do
                              xml.cardNumber credit_card.card_number if credit_card.card_number.present?
                              xml.expirationDate credit_card.expires_on.strftime("%Y-%m") if credit_card.expires_on.present?
                  Severity: Minor
                  Found in lib/vaulted_billing/gateways/authorize_net_cim.rb - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method add_customer has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                        def add_customer(customer)
                          customer = customer.to_vaulted_billing
                          data = build_request('createCustomerProfileRequest') do |xml|
                            xml.tag!('profile') do
                              xml.merchantCustomerId customer.merchant_id if customer.merchant_id
                  Severity: Minor
                  Found in lib/vaulted_billing/gateways/authorize_net_cim.rb - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method request has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def request(method, uris, body = nil, options = {})
                        uri = uris.shift || raise(ArgumentError, "URI is empty")
                  
                        request = case method
                        when :get
                  Severity: Minor
                  Found in lib/vaulted_billing/http.rb - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method respond_with has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                        def respond_with(object, response = nil, options = {}, &block)
                          super(object, options, &block).tap do |o|
                            if response
                              o.raw_response = response.raw_response.try(:body)
                              o.connection_error = response.connection_error
                  Severity: Minor
                  Found in lib/vaulted_billing/gateways/nmi_customer_vault.rb - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method respond_with has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def respond_with(object, options = {})
                        object.tap do |o|
                          o.extend(VaultedBilling::Gateway::Response)
                          o.success = options.has_key?(:success) ? options[:success] : true
                          o.raw_response = options[:raw_response] || ''
                  Severity: Minor
                  Found in lib/vaulted_billing/gateway.rb - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def initialize(options = {})
                        options = options.with_indifferent_access
                        self.test_mode = options.has_key?(:test_mode) ? options[:test_mode] : true
                        @_authorize_net_cim = GatewayConfiguration.new(options[:authorize_net_cim]) if options[:authorize_net_cim]
                        @_ipcommerce = GatewayConfiguration.new(options[:ipcommerce]) if options[:ipcommerce]
                  Severity: Minor
                  Found in lib/vaulted_billing/configuration.rb - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language