Sign upLogin

etsy/morgue

View on GitHub
Star
features/anniversary/lib.php

Summary

Maintainability
A
1 hr
Test Coverage

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        try {
            $ret = array();
            $stmt = $conn->prepare($sql);
            $stmt->execute();
            while ($row = $stmt->fetch(PDO::FETCH_ASSOC)) {
Severity: Major
Found in features/anniversary/lib.php and 1 other location - About 1 hr to fix
features/calendar/lib.php on lines 32..42

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 115.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class Anniversary extends Persistence {
Severity: Minor
Found in features/anniversary/lib.php by phpcodesniffer

The closing brace for the class must go on the next line after the body
Open

}
Severity: Minor
Found in features/anniversary/lib.php by phpcodesniffer

Opening brace of a class must be on the line after the definition
Open

class Anniversary extends Persistence {
Severity: Minor
Found in features/anniversary/lib.php by phpcodesniffer

Method name "Anniversary::render_outage" is not in camel caps format
Open

static function render_outage($pm) {
Severity: Minor
Found in features/anniversary/lib.php by phpcodesniffer

Method name "Anniversary::get_ids" is not in camel caps format
Open

    public static function get_ids($in_date = null, $conn = null) {
Severity: Minor
Found in features/anniversary/lib.php by phpcodesniffer

Visibility must be declared on method "render_outage"
Open

static function render_outage($pm) {
Severity: Minor
Found in features/anniversary/lib.php by phpcodesniffer

Method name "Anniversary::render_tags" is not in camel caps format
Open

static function render_tags($tags) {
Severity: Minor
Found in features/anniversary/lib.php by phpcodesniffer

Visibility must be declared on method "render_tags"
Open

static function render_tags($tags) {
Severity: Minor
Found in features/anniversary/lib.php by phpcodesniffer

Line indented incorrectly; expected at least 12 spaces, found 8
Open

        $tag['title'] = ucfirst($tag['title']);
Severity: Minor
Found in features/anniversary/lib.php by phpcodesniffer

Line indented incorrectly; expected 8 spaces, found 4
Open

    foreach ($tags as $tag) {
Severity: Minor
Found in features/anniversary/lib.php by phpcodesniffer

Line indented incorrectly; expected 4 spaces, found 0
Open

static function render_tags($tags) {
Severity: Minor
Found in features/anniversary/lib.php by phpcodesniffer

Line indented incorrectly; expected 8 spaces, found 4
Open

    }
Severity: Minor
Found in features/anniversary/lib.php by phpcodesniffer

Line indented incorrectly; expected 8 spaces, found 4
Open

    }
Severity: Minor
Found in features/anniversary/lib.php by phpcodesniffer

Line indented incorrectly; expected 8 spaces, found 4
Open

    }
Severity: Minor
Found in features/anniversary/lib.php by phpcodesniffer

Line indented incorrectly; expected 4 spaces, found 0
Open

static function render_outage($pm) {
Severity: Minor
Found in features/anniversary/lib.php by phpcodesniffer

Line indented incorrectly; expected at least 8 spaces, found 4
Open

    return $out;
Severity: Minor
Found in features/anniversary/lib.php by phpcodesniffer

Opening brace should be on a new line
Open

    public static function get_ids($in_date = null, $conn = null) {
Severity: Minor
Found in features/anniversary/lib.php by phpcodesniffer

Line indented incorrectly; expected at least 8 spaces, found 4
Open

    $nice_start = date("r", $pm['starttime']);
Severity: Minor
Found in features/anniversary/lib.php by phpcodesniffer

Expected 1 space after CATCH keyword; 0 found
Open

        } catch(PDOException $e) {
Severity: Minor
Found in features/anniversary/lib.php by phpcodesniffer

Line indented incorrectly; expected 4 spaces, found 0
Open

}
Severity: Minor
Found in features/anniversary/lib.php by phpcodesniffer

Line indented incorrectly; expected at least 8 spaces, found 4
Open

    $out = <<<HTML
Severity: Minor
Found in features/anniversary/lib.php by phpcodesniffer

Line indented incorrectly; expected 8 spaces, found 4
Open

    if (empty($pm['title'])) {
Severity: Minor
Found in features/anniversary/lib.php by phpcodesniffer

Line indented incorrectly; expected 8 spaces, found 4
Open

    if (!$nice_tags) {
Severity: Minor
Found in features/anniversary/lib.php by phpcodesniffer

Line indented incorrectly; expected at least 12 spaces, found 8
Open

        $nice_tags = "This event has no tags";
Severity: Minor
Found in features/anniversary/lib.php by phpcodesniffer

Opening brace should be on a new line
Open

static function render_tags($tags) {
Severity: Minor
Found in features/anniversary/lib.php by phpcodesniffer

Opening brace should be on a new line
Open

static function render_outage($pm) {
Severity: Minor
Found in features/anniversary/lib.php by phpcodesniffer

Line indented incorrectly; expected at least 8 spaces, found 4
Open

    return $out;
Severity: Minor
Found in features/anniversary/lib.php by phpcodesniffer

Line indented incorrectly; expected at least 8 spaces, found 4
Open

    $out = '';
Severity: Minor
Found in features/anniversary/lib.php by phpcodesniffer

Line indented incorrectly; expected at least 12 spaces, found 8
Open

        $pm['title'] = "untitled";
Severity: Minor
Found in features/anniversary/lib.php by phpcodesniffer

Line indented incorrectly; expected at least 8 spaces, found 4
Open

    $nice_tags = self::render_tags($pm['tags']);
Severity: Minor
Found in features/anniversary/lib.php by phpcodesniffer

Line indented incorrectly; expected 4 spaces, found 0
Open

}
Severity: Minor
Found in features/anniversary/lib.php by phpcodesniffer

Line indented incorrectly; expected at least 12 spaces, found 8
Open

        $out .= "<span class='label tag' id='tag-" .$tag['id'] . "'>{$tag['title']}</span>&nbsp;";
Severity: Minor
Found in features/anniversary/lib.php by phpcodesniffer

Line indented incorrectly; expected at least 8 spaces, found 4
Open

    $nice_end= date("r", $pm['endtime']);
Severity: Minor
Found in features/anniversary/lib.php by phpcodesniffer

There are no issues that match your filters.

Category
Status