Sign upLogin

evansiroky/gtfs-sequelize

View on GitHub
Star
lib/gtfsLoader.js

Summary

Maintainability
F
6 days
Test Coverage

File gtfsLoader.js has 625 lines of code (exceeds 250 allowed). Consider refactoring.
Open

var fs = require('fs')
var path = require('path')

var async = require('async')
var csv = require('csvtojson')
Severity: Major
Found in lib/gtfsLoader.js - About 1 day to fix

    Function loadGtfs has 248 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    var loadGtfs = function (extractedFolder, db, isSpatial, interpolateStopTimes, callback) {
  numAgencies = 0
  lastAgencyId = null

  var dropAllTables = function (dropCallback) {
    Severity: Major
    Found in lib/gtfsLoader.js - About 1 day to fix

      Function loadGtfs has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
      Open

      var loadGtfs = function (extractedFolder, db, isSpatial, interpolateStopTimes, callback) {
  numAgencies = 0
  lastAgencyId = null

  var dropAllTables = function (dropCallback) {
      Severity: Minor
      Found in lib/gtfsLoader.js - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function loadAllFiles has 82 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        var loadAllFiles = function (loadingCallback) {
    function makeCallbackLogger (name, cb) {
      return (err) => {
        if (err) {
          console.error('error loading ' + name)
      Severity: Major
      Found in lib/gtfsLoader.js - About 3 hrs to fix

        Function loadCalendarDates has 81 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        var loadCalendarDates = function (extractedFolder, db, callback) {
  var filename = path.join(extractedFolder, 'calendar_dates.txt')

  console.log('Processing ' + filename)
        Severity: Major
        Found in lib/gtfsLoader.js - About 3 hrs to fix

          Function processCalendarDates has 65 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            var processCalendarDates = function () {
    db.calendar_date.sync({force: true}).then(function () {
      var serviceIdsNotInCalendar = []
      var calendarInserterConfig = util.makeStreamerConfig(db.calendar)
          Severity: Major
          Found in lib/gtfsLoader.js - About 2 hrs to fix

            Function makeShapeTable has 50 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              var makeShapeTable = function (seriesCallback) {
    if (!hasShapeTable) {
      console.log('shape table does not exist, skipping creation of shape_gis table')
      return seriesCallback()
    }
            Severity: Minor
            Found in lib/gtfsLoader.js - About 2 hrs to fix

              Function insertCSVInTable has 50 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              var insertCSVInTable = function (insertCfg, callback) {
  console.log('Processing ' + insertCfg.filename)

  // prepare transformer in case it doesn't exist
  var transformer = insertCfg.transformer
              Severity: Minor
              Found in lib/gtfsLoader.js - About 2 hrs to fix

                Function loadCalendar has 49 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                var loadCalendar = function (extractedFolder, db, callback) {
  // reset all these things on each feed load
  minDateFound = null
  maxDateFound = null
  serviceIds = []
                Severity: Minor
                Found in lib/gtfsLoader.js - About 1 hr to fix

                  Function makeStopGeom has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    var makeStopGeom = function (seriesCallback) {
    console.log('adding stop geometry')
    var model = db.sequelize.import('../models/spatial/stop.js')
    var dialect = db.sequelize.getDialect()
    var alterStopTableQuery, geomUpdateQuery
                  Severity: Minor
                  Found in lib/gtfsLoader.js - About 1 hr to fix

                    Function dropAllTables has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      var dropAllTables = function (dropCallback) {
    var models = [db.feed_info,
      db.transfer,
      db.frequency,
      db.stop_time,
                    Severity: Minor
                    Found in lib/gtfsLoader.js - About 1 hr to fix

                      Function exports has 6 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                        downloadsDir,
  gtfsFileOrFolder,
  db,
  isSpatial,
  interpolateStopTimes,
                      Severity: Minor
                      Found in lib/gtfsLoader.js - About 45 mins to fix

                        Function loadGtfs has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                        var loadGtfs = function (extractedFolder, db, isSpatial, interpolateStopTimes, callback) {
                        Severity: Minor
                        Found in lib/gtfsLoader.js - About 35 mins to fix

                          Function insertCSVInTable has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                          var insertCSVInTable = function (insertCfg, callback) {
  console.log('Processing ' + insertCfg.filename)

  // prepare transformer in case it doesn't exist
  var transformer = insertCfg.transformer
                          Severity: Minor
                          Found in lib/gtfsLoader.js - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                if (db.sequelize.options.schema) {
        alterStopTableQuery += "'" + db.sequelize.options.schema + "', 'stop'"
      } else {
        alterStopTableQuery += "'stop'"
      }
                          Severity: Major
                          Found in lib/gtfsLoader.js and 1 other location - About 1 hr to fix
                          lib/gtfsLoader.js on lines 116..120

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 57.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                if (db.sequelize.options.schema) {
        alterStopTableQuery += '`' + db.sequelize.options.schema + '.stop`'
      } else {
        alterStopTableQuery += 'stop'
      }
                          Severity: Major
                          Found in lib/gtfsLoader.js and 1 other location - About 1 hr to fix
                          lib/gtfsLoader.js on lines 127..131

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 57.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                          var loadStops = function (extractedFolder, db, callback) {
  insertCSVInTable({
    fileIsRequired: true,
    filename: path.join(extractedFolder, 'stops.txt'),
    model: db.stop
                          Severity: Minor
                          Found in lib/gtfsLoader.js and 1 other location - About 50 mins to fix
                          lib/gtfsLoader.js on lines 600..607

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 52.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                          var loadTrips = function (extractedFolder, db, callback) {
  insertCSVInTable({
    fileIsRequired: true,
    filename: path.join(extractedFolder, 'trips.txt'),
    model: db.trip
                          Severity: Minor
                          Found in lib/gtfsLoader.js and 1 other location - About 50 mins to fix
                          lib/gtfsLoader.js on lines 394..401

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 52.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 4 locations. Consider refactoring.
                          Open

                          var loadFeedInfo = function (extractedFolder, db, callback) {
  insertCSVInTable({
    filename: path.join(extractedFolder, 'feed_info.txt'),
    model: db.feed_info
  },
                          Severity: Major
                          Found in lib/gtfsLoader.js and 3 other locations - About 35 mins to fix
                          lib/gtfsLoader.js on lines 630..636
                          lib/gtfsLoader.js on lines 638..644
                          lib/gtfsLoader.js on lines 684..690

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 47.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 4 locations. Consider refactoring.
                          Open

                          var loadFareAttributes = function (extractedFolder, db, callback) {
  insertCSVInTable({
    filename: path.join(extractedFolder, 'fare_attributes.txt'),
    model: db.fare_attribute
  },
                          Severity: Major
                          Found in lib/gtfsLoader.js and 3 other locations - About 35 mins to fix
                          lib/gtfsLoader.js on lines 638..644
                          lib/gtfsLoader.js on lines 684..690
                          lib/gtfsLoader.js on lines 692..698

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 47.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 4 locations. Consider refactoring.
                          Open

                          var loadFareRules = function (extractedFolder, db, callback) {
  insertCSVInTable({
    filename: path.join(extractedFolder, 'fare_rules.txt'),
    model: db.fare_rule
  },
                          Severity: Major
                          Found in lib/gtfsLoader.js and 3 other locations - About 35 mins to fix
                          lib/gtfsLoader.js on lines 630..636
                          lib/gtfsLoader.js on lines 684..690
                          lib/gtfsLoader.js on lines 692..698

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 47.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 4 locations. Consider refactoring.
                          Open

                          var loadTransfers = function (extractedFolder, db, callback) {
  insertCSVInTable({
    filename: path.join(extractedFolder, 'transfers.txt'),
    model: db.transfer
  },
                          Severity: Major
                          Found in lib/gtfsLoader.js and 3 other locations - About 35 mins to fix
                          lib/gtfsLoader.js on lines 630..636
                          lib/gtfsLoader.js on lines 638..644
                          lib/gtfsLoader.js on lines 692..698

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 47.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          There are no issues that match your filters.

                          Category
                          Status