eventbrite/dorsal

View on GitHub

Showing 11 of 11 total issues

Function exports has 105 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(grunt) {
    grunt.initConfig({
        pkg: grunt.file.readJSON('package.json'),

        clean: {
Severity: Major
Found in Gruntfile.js - About 4 hrs to fix

    File dorsal.js has 272 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
     * Copyright 2014 Eventbrite
     * Licensed under the Apache License, Version 2.0 (the "License");
     * you may not use this file except in compliance with the License.
     *
    Severity: Minor
    Found in src/dorsal.js - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          dfd.reject = function() {
              var i,
                  length = failFns.length;
      
              status = 'rejected';
      Severity: Major
      Found in src/dorsal_deferred.js and 1 other location - About 2 hrs to fix
      src/dorsal_deferred.js on lines 79..90

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 77.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          dfd.resolve = function() {
              var i,
                  length = doneFns.length;
      
              status = 'resolved';
      Severity: Major
      Found in src/dorsal_deferred.js and 1 other location - About 2 hrs to fix
      src/dorsal_deferred.js on lines 66..77

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 77.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function wire has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

      DorsalCore.prototype.wire = function(el, pluginName) {
          var deferred = new DorsalDeferred(this.ELEMENT_TO_PLUGINS_MAP),
              responses = [],
              action;
      
      
      Severity: Minor
      Found in src/dorsal.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _runPlugin has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      DorsalCore.prototype._runPlugin = function(el, pluginName) {
          // if already initialized, don't reinitialize
          var log = new DorsalLog(this.DEBUG);
      
          if (el.getAttribute(this.DATA_DORSAL_WIRED) && el.getAttribute(this.DATA_DORSAL_WIRED).indexOf(pluginName) !== -1) {
      Severity: Minor
      Found in src/dorsal.js - About 1 hr to fix

        Function _wireElement has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        DorsalCore.prototype._wireElement = function(el, plugins) {
            var self = this,
                dfd = new DorsalDeferred(),
                log = new DorsalLog(this.DEBUG);
        
        
        Severity: Minor
        Found in src/dorsal.js - About 1 hr to fix

          Function wire has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          DorsalCore.prototype.wire = function(el, pluginName) {
              var deferred = new DorsalDeferred(this.ELEMENT_TO_PLUGINS_MAP),
                  responses = [],
                  action;
          
          
          Severity: Minor
          Found in src/dorsal.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    fail: function(fn) {
                        if (status === 'rejected') {
                            fn.call(dfd, instances);
                        }
            
            
            Severity: Major
            Found in src/dorsal_deferred.js and 1 other location - About 1 hr to fix
            src/dorsal_deferred.js on lines 28..36

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    done: function(fn) {
                        if (status === 'resolved') {
                            fn.call(dfd, instances);
                        }
            
            
            Severity: Major
            Found in src/dorsal_deferred.js and 1 other location - About 1 hr to fix
            src/dorsal_deferred.js on lines 37..45

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function _runPlugin has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            DorsalCore.prototype._runPlugin = function(el, pluginName) {
                // if already initialized, don't reinitialize
                var log = new DorsalLog(this.DEBUG);
            
                if (el.getAttribute(this.DATA_DORSAL_WIRED) && el.getAttribute(this.DATA_DORSAL_WIRED).indexOf(pluginName) !== -1) {
            Severity: Minor
            Found in src/dorsal.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language