eventmachine/eventmachine

View on GitHub
ext/extconf.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method dir_config_wrapper has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

def dir_config_wrapper(pretty_name, name, idefault=nil, ldefault=nil)
  inc, lib = dir_config(name, idefault, ldefault)
  if inc && lib
    unless idefault && ldefault
      abort "-----\nCannot find #{pretty_name} include path #{inc}\n-----" unless inc && inc.split(File::PATH_SEPARATOR).any? { |dir| File.directory?(dir) }
Severity: Minor
Found in ext/extconf.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

  add_define 'WITH_SSL' if find_openssl_library
Severity: Major
Found in ext/extconf.rb - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

    elsif find_openssl_library
      # If we don't even need any options to find a usable OpenSSL, go with it
      add_define 'WITH_SSL'
    elsif dir_config_search('OpenSSL', 'openssl', ['/usr/local', '/opt/local', '/usr/local/opt/openssl']) do
        find_openssl_library
    Severity: Major
    Found in ext/extconf.rb - About 45 mins to fix

      Method find_openssl_library has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      def find_openssl_library
        if $mswin || $mingw
          # required for static OpenSSL libraries
          have_library("gdi32") # OpenSSL <= 1.0.2 (for RAND_screen())
          have_library("crypt32")
      Severity: Minor
      Found in ext/extconf.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

        if CONFIG['CC'] == 'cc' && (
           `cc -flags 2>&1` =~ /Sun/ || # detect SUNWspro compiler
           `cc -V 2>&1` =~ /Sun/        # detect Solaris Studio compiler
          )
          # SUN CHAIN
      Severity: Minor
      Found in ext/extconf.rb and 1 other location - About 45 mins to fix
      ext/fastfilereader/extconf.rb on lines 65..80

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 41.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      if RbConfig::CONFIG["host_os"] =~ /mingw/
        found = RbConfig::CONFIG.values_at("CFLAGS", "CPPFLAGS").
          any? { |v| v.include?("FD_SETSIZE") }
      
        add_define "FD_SETSIZE=32767" unless found
      Severity: Minor
      Found in ext/extconf.rb and 1 other location - About 30 mins to fix
      ext/fastfilereader/extconf.rb on lines 34..41

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 33.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status