eventmachine/eventmachine

View on GitHub

Showing 147 of 147 total issues

Method processIO has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    void processIO() {
        Iterator<SelectionKey> it = mySelector.selectedKeys().iterator();
        while (it.hasNext()) {
            SelectionKey k = it.next();
            it.remove();
Severity: Minor
Found in java/src/com/rubyeventmachine/EmReactor.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method receive_line has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def receive_line line
        case @hc_mode
        when :discard_blanks
          unless line == ""
            @hc_mode = :headers
Severity: Minor
Found in lib/em/protocols/header_and_content.rb - About 1 hr to fix

    Method dispatch_conn_message has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def dispatch_conn_message msg
            case msg
            when AuthentificationClearTextPassword
              raise ArgumentError, "no password specified" if @password.nil?
              send_data PasswordMessage.new(@password).dump
    Severity: Minor
    Found in lib/em/protocols/postgres3.rb - About 1 hr to fix

      Method process_cmd has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def process_cmd line
              case line.strip
              when /^VALUE\s+(.+?)\s+(\d+)\s+(\d+)/ # VALUE <key> <flags> <bytes>
                bytes = Integer($3)
                # set_binary_mode bytes+2
      Severity: Minor
      Found in lib/em/protocols/memcache.rb - About 1 hr to fix

        Method process_data_line has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def process_data_line ln
                if ln == "."
                  if @databuffer.length > 0
                    receive_data_chunk @databuffer
                    @databuffer.clear
        Severity: Minor
        Found in lib/em/protocols/smtpserver.rb - About 1 hr to fix

          Method isAcceptable has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              void isAcceptable (SelectionKey k) {
                  ServerSocketChannel ss = (ServerSocketChannel) k.channel();
                  SocketChannel sn;
                  long b;
          
          
          Severity: Minor
          Found in java/src/com/rubyeventmachine/EmReactor.java - About 1 hr to fix

            Method receive_data has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                  def receive_data data
                    @data << data
                    while @data.length >= 5
                      pktlen = @data[1...5].unpack("N").first
                      if @data.length >= (1 + pktlen)
            Severity: Minor
            Found in lib/em/protocols/postgres3.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method eventable_write has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                def eventable_write
                  # coalesce the outbound array here, perhaps
                  @last_activity = Reactor.instance.current_loop_time
                  while data = @outbound_q.shift do
                    begin
            Severity: Minor
            Found in lib/em/pure_ruby.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method receive_header_line has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                    def receive_header_line ln
                      if ln.length == 0
                        if @header_lines.length > 0
                          process_header
                        else
            Severity: Minor
            Found in lib/em/protocols/httpclient2.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method run has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                def run
                  raise Error.new( "already running" ) if @running
                  @running = true
            
                  begin
            Severity: Minor
            Found in lib/em/pure_ruby.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method writeOutboundData has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public boolean writeOutboundData() throws IOException {
                    ByteBuffer[] bufs = new ByteBuffer[64];
                    int i;
                    long written, toWrite;
                    while (!outboundQ.isEmpty()) {
            Severity: Minor
            Found in java/src/com/rubyeventmachine/EventableSocketChannel.java - About 1 hr to fix

              Method consume_line has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      def consume_line line
                        if @state == :precommand
                          unless line =~ /\A\s*\Z/
                            @command = line
                            @state = :headers
              Severity: Minor
              Found in lib/em/protocols/stomp.rb - About 1 hr to fix

                Method process_rcpt_to has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                      def process_rcpt_to rcpt
                        unless @state.include?(:mail_from)
                          send_data "503 MAIL is required before RCPT\r\n"
                        else
                          succeeded = proc {
                Severity: Minor
                Found in lib/em/protocols/smtpserver.rb - About 1 hr to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public Object[] getPeerName (long sig) {
                          EventableChannel channel = Connections.get(sig);
                          if (channel != null) {
                              return Connections.get(sig).getPeerName();
                          }
                  Severity: Major
                  Found in java/src/com/rubyeventmachine/EmReactor.java and 1 other location - About 1 hr to fix
                  java/src/com/rubyeventmachine/EmReactor.java on lines 553..563

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 72.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public Object[] getSockName (long sig) {
                          EventableChannel channel = Connections.get(sig);
                          if (channel != null) {
                              return Connections.get(sig).getSockName();
                          }
                  Severity: Major
                  Found in java/src/com/rubyeventmachine/EmReactor.java and 1 other location - About 1 hr to fix
                  java/src/com/rubyeventmachine/EmReactor.java on lines 541..551

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 72.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method invoke_rcpt_to has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                        def invoke_rcpt_to
                          @rcpt_responses ||= []
                          l = @rcpt_responses.length
                          to = @args[:to].is_a?(Array) ? @args[:to] : [@args[:to].to_s]
                          if l < to.length
                  Severity: Minor
                  Found in lib/em/protocols/smtpclient.rb - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method dispatch_conn_message has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                        def dispatch_conn_message msg
                          case msg
                          when AuthentificationClearTextPassword
                            raise ArgumentError, "no password specified" if @password.nil?
                            send_data PasswordMessage.new(@password).dump
                  Severity: Minor
                  Found in lib/em/protocols/postgres3.rb - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method process_data has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                        def process_data
                          unless @state.include?(:rcpt)
                            send_data "503 Operation sequence error\r\n"
                          else
                            succeeded = proc {
                  Severity: Minor
                  Found in lib/em/protocols/smtpserver.rb - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method nameservers has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                        def self.nameservers
                          return @nameservers if @nameservers
                  
                          if windows?
                            _, ns = Win32::Resolv.get_resolv_info
                  Severity: Minor
                  Found in lib/em/resolver.rb - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                    def handle_direct_message(input)
                      username, message = parse_direct_message(input)
                  
                      if connection = @@connected_clients.find { |c| c.username == username }
                        puts "[dm] @#{@username} => @#{username}"
                  examples/guides/getting_started/03_simple_chat_server.rb on lines 86..93

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 44.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Severity
                  Category
                  Status
                  Source
                  Language