eventtus/uniqueness

View on GitHub

Showing 2 of 2 total issues

Method uniqueness_validation has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def uniqueness_validation
      self.class.uniqueness_options.each do |field, options|
        next unless new_record? || self.changes.has_key?(field)
        value = send(field)
        if value.nil?
Severity: Minor
Found in lib/uniqueness/model.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Useless assignment to variable - options.
Open

      options ||= {}
Severity: Minor
Found in lib/uniqueness/generator.rb by rubocop

This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

assigned but unused variable - foo

Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

Example:

# bad

def some_method
  some_var = 1
  do_something
end

Example:

# good

def some_method
  some_var = 1
  do_something(some_var)
end
Severity
Category
Status
Source
Language