Sign upLogin

exoRift/cyclone-engine

View on GitHub
Star
lib/modules/reaction-handler/index.js

Summary

Maintainability
C
1 day
Test Coverage

Function handle has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  async handle (msg, emoji, user) {
    if (!msg.content && !msg.embeds) return /* Uncached */

    // Get command
    const command = await this._getInterfaceButton(msg, emoji) || this.getReactCommand(emoji.name)
Severity: Major
Found in lib/modules/reaction-handler/index.js - About 2 hrs to fix

    Function handle has a Cognitive Complexity of 20 (exceeds 10 allowed). Consider refactoring.
    Open

      async handle (msg, emoji, user) {
    if (!msg.content && !msg.embeds) return /* Uncached */

    // Get command
    const command = await this._getInterfaceButton(msg, emoji) || this.getReactCommand(emoji.name)
    Severity: Minor
    Found in lib/modules/reaction-handler/index.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function resultPromises has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        const resultPromises = commandResults.map(async (commandResult) => {
      if (!commandResult) return

      const {
        content,
    Severity: Minor
    Found in lib/modules/reaction-handler/index.js - About 1 hr to fix

      Avoid too many return statements within this function.
      Open

          return Promise.all(resultPromises).then((results) => {
      return {
        command,
        parentInterface: command.parentInterface,
        results
      Severity: Major
      Found in lib/modules/reaction-handler/index.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            if (command.options.guildOnly && msg.channel.type) return
        Severity: Major
        Found in lib/modules/reaction-handler/index.js - About 30 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              if (deleteAfter) {
      if (!response || response instanceof Error) throw Error('Cannot delete a non-existent response with a delay of:\n' + deleteAfter)

      if (typeof deleteAfter !== 'number') throw TypeError('Supplied deleteAfter delay is not a number:\n' + deleteAfter)
          Severity: Major
          Found in lib/modules/reaction-handler/index.js and 1 other location - About 2 hrs to fix
          lib/modules/command-handler/index.js on lines 483..489

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 83.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                const {
        content,
        embed,
        file,
        options = {}
          Severity: Minor
          Found in lib/modules/reaction-handler/index.js and 1 other location - About 50 mins to fix
          lib/modules/command-handler/index.js on lines 259..264

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status