expertiza/expertiza

View on GitHub
app/assets/javascripts/ajaxtabs.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function init has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    init:function(automodeperiod){
        var persistedtab=ddajaxtabs.getCookie(this.tabinterfaceid) //get position of persisted tab (applicable if persistence is enabled)
        var selectedtab=-1 //Currently selected tab index (-1 meaning none)
        var selectedtabfromurl=this.urlparamselect(this.tabinterfaceid) //returns null or index from: tabcontent.htm?tabinterfaceid=index
        this.automodeperiod=automodeperiod || 0
Severity: Minor
Found in app/assets/javascripts/ajaxtabs.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function init has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    init:function(automodeperiod){
        var persistedtab=ddajaxtabs.getCookie(this.tabinterfaceid) //get position of persisted tab (applicable if persistence is enabled)
        var selectedtab=-1 //Currently selected tab index (-1 meaning none)
        var selectedtabfromurl=this.urlparamselect(this.tabinterfaceid) //returns null or index from: tabcontent.htm?tabinterfaceid=index
        this.automodeperiod=automodeperiod || 0
Severity: Minor
Found in app/assets/javascripts/ajaxtabs.js - About 1 hr to fix

    Function connect has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

    ddajaxtabs.connect=function(pageurl, tabinstance){
        var page_request = false
        var bustcacheparameter=""
        if (window.ActiveXObject){ //Test for support for ActiveXObject in IE first (as XMLHttpRequest in IE7 is broken)
            try {
    Severity: Minor
    Found in app/assets/javascripts/ajaxtabs.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Consider simplifying this complex logical expression.
    Open

                    if (selectedtabfromurl==i || this.enabletabpersistence && selectedtab==-1 && parseInt(persistedtab)==i || !this.enabletabpersistence && selectedtab==-1 && this.getselectedClassTarget(this.tabs[i]).className=="selected"){
                        selectedtab=i //Selected tab index, if found
                    }
    Severity: Major
    Found in app/assets/javascripts/ajaxtabs.js - About 1 hr to fix

      Function expandtab has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          expandtab:function(tabref){
              var relattrvalue=tabref.getAttribute("rel")
              //Get "rev" attr as a string of IDs in the format ",john,george,trey,etc," to easy searching through
              var associatedrevids=(tabref.getAttribute("rev"))? ","+tabref.getAttribute("rev").replace(/\s+/, "")+"," : ""
              if (relattrvalue=="#default")
      Severity: Minor
      Found in app/assets/javascripts/ajaxtabs.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function cycleit has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          cycleit:function(dir, autorun){ //PUBLIC function to move forward or backwards through each hot tab (tabinstance.cycleit('foward/back') )
              if (dir=="next"){
                  var currentTabIndex=(this.currentTabIndex<this.hottabspositions.length-1)? this.currentTabIndex+1 : 0
              }
              else if (dir=="prev"){
      Severity: Minor
      Found in app/assets/javascripts/ajaxtabs.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status