Sign upLogin

expertiza/expertiza

View on GitHub
Star
app/controllers/assignment_questionnaire_controller.rb

Summary

Maintainability
A
0 mins
Test Coverage
C
73%

Assignment Branch Condition size for create is too high. [34.94/15]
Open

  def create
    if assignment_questionnaire_params[:assignment_id].nil?
      flash[:error] = "Missing assignment"
      return
    elsif assignment_questionnaire_params[:questionnaire_id].nil?
Severity: Minor
Found in app/controllers/assignment_questionnaire_controller.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [22/10]
Open

  def create
    if assignment_questionnaire_params[:assignment_id].nil?
      flash[:error] = "Missing assignment"
      return
    elsif assignment_questionnaire_params[:questionnaire_id].nil?
Severity: Minor
Found in app/controllers/assignment_questionnaire_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for delete_all is too high. [17.29/15]
Open

  def delete_all
    assignment = Assignment.find(params[:assignment_id])

    if assignment.nil?
      flash[:error] = 'Assignment #' + params[:assignment_id].to_s + ' does not currently exist.'
Severity: Minor
Found in app/controllers/assignment_questionnaire_controller.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      flash[:error] = "Missing questionnaire"
Severity: Minor
Found in app/controllers/assignment_questionnaire_controller.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      flash[:error] = "Missing assignment"
Severity: Minor
Found in app/controllers/assignment_questionnaire_controller.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Missing top-level class documentation comment.
Open

class AssignmentQuestionnaireController < ApplicationController
Severity: Minor
Found in app/controllers/assignment_questionnaire_controller.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

There are no issues that match your filters.

Category
Status