expertiza/expertiza

View on GitHub
app/controllers/import_file_controller.rb

Summary

Maintainability
F
3 days
Test Coverage
F
0%

Class has too many lines. [264/100]
Open

class ImportFileController < ApplicationController
  include AuthorizationHelper

  def action_allowed?
    current_user_has_ta_privileges?

This cop checks if the length a class exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for import_from_hash is too high. [141.3/15]
Open

  def import_from_hash(session, params)
    if (params[:model] == 'AssignmentTeam') || (params[:model] == 'CourseTeam')
      contents_hash = eval(params[:contents_hash])
      @header_integrated_body = hash_rows_with_headers(contents_hash[:header], contents_hash[:body])
      errors = []

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [108/10]
Open

  def import_from_hash(session, params)
    if (params[:model] == 'AssignmentTeam') || (params[:model] == 'CourseTeam')
      contents_hash = eval(params[:contents_hash])
      @header_integrated_body = hash_rows_with_headers(contents_hash[:header], contents_hash[:body])
      errors = []

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for hash_rows_with_headers is too high. [88.67/15]
Open

  def hash_rows_with_headers(header, body)
    new_body = []
    if (params[:model] == 'User') || (params[:model] == 'AssignmentParticipant') || (params[:model] == 'CourseParticipant') || (params[:model] == 'SignUpTopic')
      header.map! { |str| str.strip.downcase.gsub(/\s+/, "").to_sym }
      body.each do |row|

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [55/10]
Open

  def hash_rows_with_headers(header, body)
    new_body = []
    if (params[:model] == 'User') || (params[:model] == 'AssignmentParticipant') || (params[:model] == 'CourseParticipant') || (params[:model] == 'SignUpTopic')
      header.map! { |str| str.strip.downcase.gsub(/\s+/, "").to_sym }
      body.each do |row|

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method import_from_hash has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
Open

  def import_from_hash(session, params)
    if (params[:model] == 'AssignmentTeam') || (params[:model] == 'CourseTeam')
      contents_hash = eval(params[:contents_hash])
      @header_integrated_body = hash_rows_with_headers(contents_hash[:header], contents_hash[:body])
      errors = []
Severity: Minor
Found in app/controllers/import_file_controller.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Assignment Branch Condition size for show is too high. [45.98/15]
Open

  def show
    @id = params[:id]
    @model = params[:model]
    @options = params[:options]
    @delimiter = get_delimiter(params)

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Perceived complexity for import_from_hash is too high. [32/7]
Open

  def import_from_hash(session, params)
    if (params[:model] == 'AssignmentTeam') || (params[:model] == 'CourseTeam')
      contents_hash = eval(params[:contents_hash])
      @header_integrated_body = hash_rows_with_headers(contents_hash[:header], contents_hash[:body])
      errors = []

This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Method import_from_hash has 108 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def import_from_hash(session, params)
    if (params[:model] == 'AssignmentTeam') || (params[:model] == 'CourseTeam')
      contents_hash = eval(params[:contents_hash])
      @header_integrated_body = hash_rows_with_headers(contents_hash[:header], contents_hash[:body])
      errors = []
Severity: Major
Found in app/controllers/import_file_controller.rb - About 4 hrs to fix

    Method has too many lines. [30/10]
    Open

      def show
        @id = params[:id]
        @model = params[:model]
        @options = params[:options]
        @delimiter = get_delimiter(params)

    This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

    Cyclomatic complexity for import_from_hash is too high. [25/6]
    Open

      def import_from_hash(session, params)
        if (params[:model] == 'AssignmentTeam') || (params[:model] == 'CourseTeam')
          contents_hash = eval(params[:contents_hash])
          @header_integrated_body = hash_rows_with_headers(contents_hash[:header], contents_hash[:body])
          errors = []

    This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

    An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

    Assignment Branch Condition size for import is too high. [28.65/15]
    Open

      def import
        errors = import_from_hash(session, params)
        err_msg = 'The following errors were encountered during import.<br/>Other records may have been added. A second submission will not duplicate these records.<br/><ul>'
        errors.each do |error|
          err_msg = err_msg + '<li>' + error.to_s + '<br/>'

    This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

    Perceived complexity for hash_rows_with_headers is too high. [19/7]
    Open

      def hash_rows_with_headers(header, body)
        new_body = []
        if (params[:model] == 'User') || (params[:model] == 'AssignmentParticipant') || (params[:model] == 'CourseParticipant') || (params[:model] == 'SignUpTopic')
          header.map! { |str| str.strip.downcase.gsub(/\s+/, "").to_sym }
          body.each do |row|

    This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

    Example:

    def my_method                   # 1
      if cond                       # 1
        case var                    # 2 (0.8 + 4 * 0.2, rounded)
        when 1 then func_one
        when 2 then func_two
        when 3 then func_three
        when 4..10 then func_other
        end
      else                          # 1
        do_something until a && b   # 2
      end                           # ===
    end                             # 7 complexity points

    Method hash_rows_with_headers has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

      def hash_rows_with_headers(header, body)
        new_body = []
        if (params[:model] == 'User') || (params[:model] == 'AssignmentParticipant') || (params[:model] == 'CourseParticipant') || (params[:model] == 'SignUpTopic')
          header.map! { |str| str.strip.downcase.gsub(/\s+/, "").to_sym }
          body.each do |row|
    Severity: Minor
    Found in app/controllers/import_file_controller.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Cyclomatic complexity for hash_rows_with_headers is too high. [15/6]
    Open

      def hash_rows_with_headers(header, body)
        new_body = []
        if (params[:model] == 'User') || (params[:model] == 'AssignmentParticipant') || (params[:model] == 'CourseParticipant') || (params[:model] == 'SignUpTopic')
          header.map! { |str| str.strip.downcase.gsub(/\s+/, "").to_sym }
          body.each do |row|

    This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

    An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

    File import_file_controller.rb has 266 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class ImportFileController < ApplicationController
      include AuthorizationHelper
    
      def action_allowed?
        current_user_has_ta_privileges?
    Severity: Minor
    Found in app/controllers/import_file_controller.rb - About 2 hrs to fix

      Perceived complexity for show is too high. [12/7]
      Open

        def show
          @id = params[:id]
          @model = params[:model]
          @options = params[:options]
          @delimiter = get_delimiter(params)

      This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

      Example:

      def my_method                   # 1
        if cond                       # 1
          case var                    # 2 (0.8 + 4 * 0.2, rounded)
          when 1 then func_one
          when 2 then func_two
          when 3 then func_three
          when 4..10 then func_other
          end
        else                          # 1
          do_something until a && b   # 2
        end                           # ===
      end                             # 7 complexity points

      Method hash_rows_with_headers has 55 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def hash_rows_with_headers(header, body)
          new_body = []
          if (params[:model] == 'User') || (params[:model] == 'AssignmentParticipant') || (params[:model] == 'CourseParticipant') || (params[:model] == 'SignUpTopic')
            header.map! { |str| str.strip.downcase.gsub(/\s+/, "").to_sym }
            body.each do |row|
      Severity: Major
      Found in app/controllers/import_file_controller.rb - About 2 hrs to fix

        Method has too many lines. [14/10]
        Open

          def import
            errors = import_from_hash(session, params)
            err_msg = 'The following errors were encountered during import.<br/>Other records may have been added. A second submission will not duplicate these records.<br/><ul>'
            errors.each do |error|
              err_msg = err_msg + '<li>' + error.to_s + '<br/>'

        This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

        Cyclomatic complexity for show is too high. [9/6]
        Open

          def show
            @id = params[:id]
            @model = params[:model]
            @options = params[:options]
            @delimiter = get_delimiter(params)

        This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

        An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

        Method show has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

          def show
            @id = params[:id]
            @model = params[:model]
            @options = params[:options]
            @delimiter = get_delimiter(params)
        Severity: Minor
        Found in app/controllers/import_file_controller.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method show has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def show
            @id = params[:id]
            @model = params[:model]
            @options = params[:options]
            @delimiter = get_delimiter(params)
        Severity: Minor
        Found in app/controllers/import_file_controller.rb - About 1 hr to fix

          Avoid deeply nested control flow statements.
          Open

                rescue StandardError
                  errors << $ERROR_INFO
          Severity: Major
          Found in app/controllers/import_file_controller.rb - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                  if params[:has_header] == 'true'
                    @header_integrated_body = hash_rows_with_headers(contents_hash[:header], contents_hash[:body])
                  else
                    if params[:optional_count] == '0'
                      new_header = [params[:select1], params[:select2], params[:select3]]
            Severity: Major
            Found in app/controllers/import_file_controller.rb - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                  elsif params[:model] == 'AssignmentParticipant' || params[:model] == 'CourseParticipant'
                    contents_hash = eval(params[:contents_hash])
                    if params[:has_header] == 'true'
                      @header_integrated_body = hash_rows_with_headers(contents_hash[:header], contents_hash[:body])
                    else
              Severity: Major
              Found in app/controllers/import_file_controller.rb - About 45 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      header.map!(&:to_sym)
                      body.each do |row|
                        h = {}
                        if params[:has_teamname] == 'true_first'
                          h[header[0]] = row.shift
                Severity: Major
                Found in app/controllers/import_file_controller.rb and 1 other location - About 1 hr to fix
                app/controllers/import_file_controller.rb on lines 207..219

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 61.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      header.map!(&:to_sym)
                      body.each do |row|
                        h = {}
                        if params[:has_reviewee] == 'true_first'
                          h[header[0]] = row.shift
                Severity: Major
                Found in app/controllers/import_file_controller.rb and 1 other location - About 1 hr to fix
                app/controllers/import_file_controller.rb on lines 192..204

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 61.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      contents_hash = eval(params[:contents_hash])
                      @header_integrated_body = hash_rows_with_headers(contents_hash[:header], contents_hash[:body])
                      errors = []
                      begin
                        @header_integrated_body.each do |row_hash|
                Severity: Minor
                Found in app/controllers/import_file_controller.rb and 1 other location - About 35 mins to fix
                app/controllers/import_file_controller.rb on lines 96..104

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 34.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      contents_hash = eval(params[:contents_hash])
                      @header_integrated_body = hash_rows_with_headers(contents_hash[:header], contents_hash[:body])
                      errors = []
                      begin
                        @header_integrated_body.each do |row_hash|
                Severity: Minor
                Found in app/controllers/import_file_controller.rb and 1 other location - About 35 mins to fix
                app/controllers/import_file_controller.rb on lines 85..93

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 34.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Move contents_hash = eval(params[:contents_hash]) out of the conditional.
                Open

                      contents_hash = eval(params[:contents_hash])

                This cop checks for identical lines at the beginning or end of each branch of a conditional statement.

                Example:

                # bad
                if condition
                  do_x
                  do_z
                else
                  do_y
                  do_z
                end
                
                # good
                if condition
                  do_x
                else
                  do_y
                end
                do_z
                
                # bad
                if condition
                  do_z
                  do_x
                else
                  do_z
                  do_y
                end
                
                # good
                do_z
                if condition
                  do_x
                else
                  do_y
                end
                
                # bad
                case foo
                when 1
                  do_x
                when 2
                  do_x
                else
                  do_x
                end
                
                # good
                case foo
                when 1
                  do_x
                  do_y
                when 2
                  # nothing
                else
                  do_x
                  do_z
                end

                Move contents_hash = eval(params[:contents_hash]) out of the conditional.
                Open

                      contents_hash = eval(params[:contents_hash])

                This cop checks for identical lines at the beginning or end of each branch of a conditional statement.

                Example:

                # bad
                if condition
                  do_x
                  do_z
                else
                  do_y
                  do_z
                end
                
                # good
                if condition
                  do_x
                else
                  do_y
                end
                do_z
                
                # bad
                if condition
                  do_z
                  do_x
                else
                  do_z
                  do_y
                end
                
                # good
                do_z
                if condition
                  do_x
                else
                  do_y
                end
                
                # bad
                case foo
                when 1
                  do_x
                when 2
                  do_x
                else
                  do_x
                end
                
                # good
                case foo
                when 1
                  do_x
                  do_y
                when 2
                  # nothing
                else
                  do_x
                  do_z
                end

                The use of eval is a serious security risk.
                Open

                      contents_hash = eval(params[:contents_hash])

                This cop checks for the use of Kernel#eval and Binding#eval.

                Example:

                # bad
                
                eval(something)
                binding.eval(something)

                Move @optional_count = 0 out of the conditional.
                Open

                      @optional_count = 0

                This cop checks for identical lines at the beginning or end of each branch of a conditional statement.

                Example:

                # bad
                if condition
                  do_x
                  do_z
                else
                  do_y
                  do_z
                end
                
                # good
                if condition
                  do_x
                else
                  do_y
                end
                do_z
                
                # bad
                if condition
                  do_z
                  do_x
                else
                  do_z
                  do_y
                end
                
                # good
                do_z
                if condition
                  do_x
                else
                  do_y
                end
                
                # bad
                case foo
                when 1
                  do_x
                when 2
                  do_x
                else
                  do_x
                end
                
                # good
                case foo
                when 1
                  do_x
                  do_y
                when 2
                  # nothing
                else
                  do_x
                  do_z
                end

                Move contents_hash = eval(params[:contents_hash]) out of the conditional.
                Open

                      contents_hash = eval(params[:contents_hash])

                This cop checks for identical lines at the beginning or end of each branch of a conditional statement.

                Example:

                # bad
                if condition
                  do_x
                  do_z
                else
                  do_y
                  do_z
                end
                
                # good
                if condition
                  do_x
                else
                  do_y
                end
                do_z
                
                # bad
                if condition
                  do_z
                  do_x
                else
                  do_z
                  do_y
                end
                
                # good
                do_z
                if condition
                  do_x
                else
                  do_y
                end
                
                # bad
                case foo
                when 1
                  do_x
                when 2
                  do_x
                else
                  do_x
                end
                
                # good
                case foo
                when 1
                  do_x
                  do_y
                when 2
                  # nothing
                else
                  do_x
                  do_z
                end

                Move file_hash[:body] = import_grid out of the conditional.
                Open

                      file_hash[:body] = import_grid

                This cop checks for identical lines at the beginning or end of each branch of a conditional statement.

                Example:

                # bad
                if condition
                  do_x
                  do_z
                else
                  do_y
                  do_z
                end
                
                # good
                if condition
                  do_x
                else
                  do_y
                end
                do_z
                
                # bad
                if condition
                  do_z
                  do_x
                else
                  do_z
                  do_y
                end
                
                # good
                do_z
                if condition
                  do_x
                else
                  do_y
                end
                
                # bad
                case foo
                when 1
                  do_x
                when 2
                  do_x
                else
                  do_x
                end
                
                # good
                case foo
                when 1
                  do_x
                  do_y
                when 2
                  # nothing
                else
                  do_x
                  do_z
                end

                The use of eval is a serious security risk.
                Open

                      contents_hash = eval(params[:contents_hash])

                This cop checks for the use of Kernel#eval and Binding#eval.

                Example:

                # bad
                
                eval(something)
                binding.eval(something)

                The use of eval is a serious security risk.
                Open

                      contents_hash = eval(params[:contents_hash])

                This cop checks for the use of Kernel#eval and Binding#eval.

                Example:

                # bad
                
                eval(something)
                binding.eval(something)

                Move contents_hash = eval(params[:contents_hash]) out of the conditional.
                Open

                      contents_hash = eval(params[:contents_hash])

                This cop checks for identical lines at the beginning or end of each branch of a conditional statement.

                Example:

                # bad
                if condition
                  do_x
                  do_z
                else
                  do_y
                  do_z
                end
                
                # good
                if condition
                  do_x
                else
                  do_y
                end
                do_z
                
                # bad
                if condition
                  do_z
                  do_x
                else
                  do_z
                  do_y
                end
                
                # good
                do_z
                if condition
                  do_x
                else
                  do_y
                end
                
                # bad
                case foo
                when 1
                  do_x
                when 2
                  do_x
                else
                  do_x
                end
                
                # good
                case foo
                when 1
                  do_x
                  do_y
                when 2
                  # nothing
                else
                  do_x
                  do_z
                end

                The use of eval is a serious security risk.
                Open

                      contents_hash = eval(params[:contents_hash])

                This cop checks for the use of Kernel#eval and Binding#eval.

                Example:

                # bad
                
                eval(something)
                binding.eval(something)

                Move file_hash[:body] = import_grid out of the conditional.
                Open

                      file_hash[:body] = import_grid

                This cop checks for identical lines at the beginning or end of each branch of a conditional statement.

                Example:

                # bad
                if condition
                  do_x
                  do_z
                else
                  do_y
                  do_z
                end
                
                # good
                if condition
                  do_x
                else
                  do_y
                end
                do_z
                
                # bad
                if condition
                  do_z
                  do_x
                else
                  do_z
                  do_y
                end
                
                # good
                do_z
                if condition
                  do_x
                else
                  do_y
                end
                
                # bad
                case foo
                when 1
                  do_x
                when 2
                  do_x
                else
                  do_x
                end
                
                # good
                case foo
                when 1
                  do_x
                  do_y
                when 2
                  # nothing
                else
                  do_x
                  do_z
                end

                The use of eval is a serious security risk.
                Open

                      contents_hash = eval(params[:contents_hash])

                This cop checks for the use of Kernel#eval and Binding#eval.

                Example:

                # bad
                
                eval(something)
                binding.eval(something)

                Move @optional_count = 0 out of the conditional.
                Open

                      @optional_count = 0

                This cop checks for identical lines at the beginning or end of each branch of a conditional statement.

                Example:

                # bad
                if condition
                  do_x
                  do_z
                else
                  do_y
                  do_z
                end
                
                # good
                if condition
                  do_x
                else
                  do_y
                end
                do_z
                
                # bad
                if condition
                  do_z
                  do_x
                else
                  do_z
                  do_y
                end
                
                # good
                do_z
                if condition
                  do_x
                else
                  do_y
                end
                
                # bad
                case foo
                when 1
                  do_x
                when 2
                  do_x
                else
                  do_x
                end
                
                # good
                case foo
                when 1
                  do_x
                  do_y
                when 2
                  # nothing
                else
                  do_x
                  do_z
                end

                The use of eval is a serious security risk.
                Open

                      contents_hash = eval(params[:contents_hash])

                This cop checks for the use of Kernel#eval and Binding#eval.

                Example:

                # bad
                
                eval(something)
                binding.eval(something)

                Missing top-level class documentation comment.
                Open

                class ImportFileController < ApplicationController

                This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

                The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

                Example:

                # bad
                class Person
                  # ...
                end
                
                # good
                # Description/Explanation of Person class
                class Person
                  # ...
                end

                Move contents_hash = eval(params[:contents_hash]) out of the conditional.
                Open

                      contents_hash = eval(params[:contents_hash])

                This cop checks for identical lines at the beginning or end of each branch of a conditional statement.

                Example:

                # bad
                if condition
                  do_x
                  do_z
                else
                  do_y
                  do_z
                end
                
                # good
                if condition
                  do_x
                else
                  do_y
                end
                do_z
                
                # bad
                if condition
                  do_z
                  do_x
                else
                  do_z
                  do_y
                end
                
                # good
                do_z
                if condition
                  do_x
                else
                  do_y
                end
                
                # bad
                case foo
                when 1
                  do_x
                when 2
                  do_x
                else
                  do_x
                end
                
                # good
                case foo
                when 1
                  do_x
                  do_y
                when 2
                  # nothing
                else
                  do_x
                  do_z
                end

                Convert if nested inside else to elsif.
                Open

                        if params[:optional_count] == '0'

                If the else branch of a conditional consists solely of an if node, it can be combined with the else to become an elsif. This helps to keep the nesting level from getting too deep.

                Example:

                # bad
                if condition_a
                  action_a
                else
                  if condition_b
                    action_b
                  else
                    action_c
                  end
                end
                
                # good
                if condition_a
                  action_a
                elsif condition_b
                  action_b
                else
                  action_c
                end

                Move contents_hash = eval(params[:contents_hash]) out of the conditional.
                Open

                      contents_hash = eval(params[:contents_hash])

                This cop checks for identical lines at the beginning or end of each branch of a conditional statement.

                Example:

                # bad
                if condition
                  do_x
                  do_z
                else
                  do_y
                  do_z
                end
                
                # good
                if condition
                  do_x
                else
                  do_y
                end
                do_z
                
                # bad
                if condition
                  do_z
                  do_x
                else
                  do_z
                  do_y
                end
                
                # good
                do_z
                if condition
                  do_x
                else
                  do_y
                end
                
                # bad
                case foo
                when 1
                  do_x
                when 2
                  do_x
                else
                  do_x
                end
                
                # good
                case foo
                when 1
                  do_x
                  do_y
                when 2
                  # nothing
                else
                  do_x
                  do_z
                end

                Prefer single-quoted strings when you don't need string interpolation or special symbols.
                Open

                      header.map! { |str| str.strip.downcase.gsub(/\s+/, "").to_sym }

                Checks if uses of quotes match the configured preference.

                Example: EnforcedStyle: single_quotes (default)

                # bad
                "No special symbols"
                "No string interpolation"
                "Just text"
                
                # good
                'No special symbols'
                'No string interpolation'
                'Just text'
                "Wait! What's #{this}!"

                Example: EnforcedStyle: double_quotes

                # bad
                'Just some text'
                'No special chars or interpolation'
                
                # good
                "Just some text"
                "No special chars or interpolation"
                "Every string in #{project} uses double_quotes"

                There are no issues that match your filters.

                Category
                Status