expertiza/expertiza

View on GitHub
app/controllers/sign_up_sheet_controller.rb

Summary

Maintainability
D
2 days
Test Coverage
A
93%

Possible SQL injection
Confirmed

    SignUpTopic.find(params[:topic_id]).update_attribute(:private_to, nil) if SignUpTopic.exists?(params[:topic_id])

Injection is #1 on the 2013 OWASP Top Ten web security risks. SQL injection is when a user is able to manipulate a value which is used unsafely inside a SQL query. This can lead to data leaks, data loss, elevation of privilege, and other unpleasant outcomes.

Brakeman focuses on ActiveRecord methods dealing with building SQL statements.

A basic (Rails 2.x) example looks like this:

User.first(:conditions => "username = '#{params[:username]}'")

Brakeman would produce a warning like this:

Possible SQL injection near line 30: User.first(:conditions => ("username = '#{params[:username]}'"))

The safe way to do this query is to use a parameterized query:

User.first(:conditions => ["username = ?", params[:username]])

Brakeman also understands the new Rails 3.x way of doing things (and local variables and concatenation):

username = params[:user][:name].downcase
password = params[:user][:password]

User.first.where("username = '" + username + "' AND password = '" + password + "'")

This results in this kind of warning:

Possible SQL injection near line 37:
User.first.where((((("username = '" + params[:user][:name].downcase) + "' AND password = '") + params[:user][:password]) + "'"))

See the Ruby Security Guide for more information and Rails-SQLi.org for many examples of SQL injection in Rails.

Possible SQL injection
Confirmed

    SignUpTopic.find(params[:topic_id]).update_attribute(:private_to, nil) if SignUpTopic.exists?(params[:topic_id])

Injection is #1 on the 2013 OWASP Top Ten web security risks. SQL injection is when a user is able to manipulate a value which is used unsafely inside a SQL query. This can lead to data leaks, data loss, elevation of privilege, and other unpleasant outcomes.

Brakeman focuses on ActiveRecord methods dealing with building SQL statements.

A basic (Rails 2.x) example looks like this:

User.first(:conditions => "username = '#{params[:username]}'")

Brakeman would produce a warning like this:

Possible SQL injection near line 30: User.first(:conditions => ("username = '#{params[:username]}'"))

The safe way to do this query is to use a parameterized query:

User.first(:conditions => ["username = ?", params[:username]])

Brakeman also understands the new Rails 3.x way of doing things (and local variables and concatenation):

username = params[:user][:name].downcase
password = params[:user][:password]

User.first.where("username = '" + username + "' AND password = '" + password + "'")

This results in this kind of warning:

Possible SQL injection near line 37:
User.first.where((((("username = '" + params[:user][:name].downcase) + "' AND password = '") + params[:user][:password]) + "'"))

See the Ruby Security Guide for more information and Rails-SQLi.org for many examples of SQL injection in Rails.

Assignment Branch Condition size for save_topic_deadlines is too high. [162.6/15]
Open

  def save_topic_deadlines
    assignment = Assignment.find(params[:assignment_id])
    @assignment_submission_due_dates = assignment.due_dates.select {|due_date| due_date.deadline_type_id == 1 }
    @assignment_review_due_dates = assignment.due_dates.select {|due_date| due_date.deadline_type_id == 2 }
    due_dates = params[:due_date]

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Assignment Branch Condition size for delete_signup_as_instructor is too high. [66.6/15]
Open

  def delete_signup_as_instructor
    # find participant using assignment using team and topic ids
    team = Team.find(params[:id])
    assignment = Assignment.find(team.parent_id)
    user = TeamsUser.find_by(team_id: team.id).user

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Assignment Branch Condition size for delete_signup is too high. [62.42/15]
Open

  def delete_signup
    participant = AssignmentParticipant.find(params[:id])
    assignment = participant.assignment
    drop_topic_deadline = assignment.due_dates.find_by(deadline_type_id: 6)
    # A student who has already submitted work should not be allowed to drop his/her topic!

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Assignment Branch Condition size for list is too high. [57.25/15]
Open

  def list
    @participant = AssignmentParticipant.find(params[:id].to_i)
    @assignment = @participant.assignment
    @slots_filled = SignUpTopic.find_slots_filled(@assignment.id)
    @slots_waitlisted = SignUpTopic.find_slots_waitlisted(@assignment.id)

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

File sign_up_sheet_controller.rb has 380 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class SignUpSheetController < ApplicationController
  require 'rgl/adjacency'
  require 'rgl/dot'
  require 'rgl/topsort'

Severity: Minor
Found in app/controllers/sign_up_sheet_controller.rb - About 5 hrs to fix

    Assignment Branch Condition size for set_priority is too high. [44.03/15]
    Open

      def set_priority
        participant = AssignmentParticipant.find_by(id: params[:participant_id])
        assignment_id = SignUpTopic.find(params[:topic].first).assignment.id
        team_id = participant.team.try(:id)
        unless team_id

    This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

    Assignment Branch Condition size for switch_original_topic_to_approved_suggested_topic is too high. [41.41/15]
    Open

      def switch_original_topic_to_approved_suggested_topic
        assignment = AssignmentParticipant.find(params[:id]).assignment
        team_id = TeamsUser.team_id(assignment.id, session[:user].id)
        original_topic_id = SignedUpTeam.topic_id(assignment.id.to_i, session[:user].id)
        SignUpTopic.find(params[:topic_id]).update_attribute(:private_to, nil) if SignUpTopic.exists?(params[:topic_id])

    This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

    Assignment Branch Condition size for signup_as_instructor_action is too high. [36.47/15]
    Open

      def signup_as_instructor_action
        user = User.find_by(name: params[:username])
        if user.nil? # validate invalid user
          flash[:error] = "That student does not exist!"
        else

    This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

    Assignment Branch Condition size for update is too high. [32.03/15]
    Open

      def update
        @topic = SignUpTopic.find(params[:id])
        if @topic
          @topic.topic_identifier = params[:topic][:topic_identifier]
          update_max_choosers @topic

    This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

    Class SignUpSheetController has 29 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class SignUpSheetController < ApplicationController
      require 'rgl/adjacency'
      require 'rgl/dot'
      require 'rgl/topsort'
    
    
    Severity: Minor
    Found in app/controllers/sign_up_sheet_controller.rb - About 3 hrs to fix

      Assignment Branch Condition size for show_team is too high. [27.09/15]
      Open

        def show_team
          if !(assignment = Assignment.find(params[:assignment_id])).nil? and !(topic = SignUpTopic.find(params[:id])).nil?
            @results = ad_info(assignment.id, topic.id)
            @results.each do |result|
              result.keys.each do |key|

      This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

      Assignment Branch Condition size for update_max_choosers is too high. [26.34/15]
      Open

        def update_max_choosers(topic)
          # While saving the max choosers you should be careful; if there are users who have signed up for this particular
          # topic and are on waitlist, then they have to be converted to confirmed topic based on the availability. But if
          # there are choosers already and if there is an attempt to decrease the max choosers, as of now I am not allowing
          # it.

      This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

      Method list has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

        def list
          @participant = AssignmentParticipant.find(params[:id].to_i)
          @assignment = @participant.assignment
          @slots_filled = SignUpTopic.find_slots_filled(@assignment.id)
          @slots_waitlisted = SignUpTopic.find_slots_waitlisted(@assignment.id)
      Severity: Minor
      Found in app/controllers/sign_up_sheet_controller.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Assignment Branch Condition size for destroy is too high. [20.32/15]
      Open

        def destroy
          @topic = SignUpTopic.find(params[:id])
          assignment = Assignment.find(params[:assignment_id])
          if @topic
            @topic.destroy

      This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

      Perceived complexity for list is too high. [12/7]
      Open

        def list
          @participant = AssignmentParticipant.find(params[:id].to_i)
          @assignment = @participant.assignment
          @slots_filled = SignUpTopic.find_slots_filled(@assignment.id)
          @slots_waitlisted = SignUpTopic.find_slots_waitlisted(@assignment.id)

      This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

      Example:

      def my_method                   # 1
        if cond                       # 1
          case var                    # 2 (0.8 + 4 * 0.2, rounded)
          when 1 then func_one
          when 2 then func_two
          when 3 then func_three
          when 4..10 then func_other
          end
        else                          # 1
          do_something until a && b   # 2
        end                           # ===
      end                             # 7 complexity points

      Cyclomatic complexity for list is too high. [11/6]
      Open

        def list
          @participant = AssignmentParticipant.find(params[:id].to_i)
          @assignment = @participant.assignment
          @slots_filled = SignUpTopic.find_slots_filled(@assignment.id)
          @slots_waitlisted = SignUpTopic.find_slots_waitlisted(@assignment.id)

      This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

      An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

      Assignment Branch Condition size for set_values_for_new_topic is too high. [19.31/15]
      Open

        def set_values_for_new_topic
          @sign_up_topic = SignUpTopic.new
          @sign_up_topic.topic_identifier = params[:topic][:topic_identifier]
          @sign_up_topic.topic_name = params[:topic][:topic_name]
          @sign_up_topic.max_choosers = params[:topic][:max_choosers]

      This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

      Method save_topic_deadlines has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

        def save_topic_deadlines
          assignment = Assignment.find(params[:assignment_id])
          @assignment_submission_due_dates = assignment.due_dates.select {|due_date| due_date.deadline_type_id == 1 }
          @assignment_review_due_dates = assignment.due_dates.select {|due_date| due_date.deadline_type_id == 2 }
          due_dates = params[:due_date]
      Severity: Minor
      Found in app/controllers/sign_up_sheet_controller.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method save_topic_deadlines has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def save_topic_deadlines
          assignment = Assignment.find(params[:assignment_id])
          @assignment_submission_due_dates = assignment.due_dates.select {|due_date| due_date.deadline_type_id == 1 }
          @assignment_review_due_dates = assignment.due_dates.select {|due_date| due_date.deadline_type_id == 2 }
          due_dates = params[:due_date]
      Severity: Minor
      Found in app/controllers/sign_up_sheet_controller.rb - About 1 hr to fix

        Assignment Branch Condition size for setup_new_topic is too high. [17.52/15]
        Open

          def setup_new_topic
            set_values_for_new_topic
            @sign_up_topic.micropayment = params[:topic][:micropayment] if @assignment.microtask?
            if @assignment.staggered_deadline?
              topic_set = []

        This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

        Assignment Branch Condition size for sign_up is too high. [15.33/15]
        Open

          def sign_up
            @assignment = AssignmentParticipant.find(params[:id]).assignment
            @user_id = session[:user].id
            # Always use team_id ACS
            # s = Signupsheet.new

        This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

        Block has too many lines. [39/25]
        Open

            topics.each_with_index do |topic, index|
              for i in 1..review_rounds
                @topic_submission_due_date = due_dates[topics[index].id.to_s + '_submission_' + i.to_s + '_due_date']
                @topic_review_due_date = due_dates[topics[index].id.to_s + '_review_' + i.to_s + '_due_date']
                @assignment_submission_due_date = DateTime.parse(@assignment_submission_due_dates[i - 1].due_at.to_s).strftime("%Y-%m-%d %H:%M")

        This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

        Method list has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def list
            @participant = AssignmentParticipant.find(params[:id].to_i)
            @assignment = @participant.assignment
            @slots_filled = SignUpTopic.find_slots_filled(@assignment.id)
            @slots_waitlisted = SignUpTopic.find_slots_waitlisted(@assignment.id)
        Severity: Minor
        Found in app/controllers/sign_up_sheet_controller.rb - About 1 hr to fix

          Method set_priority has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def set_priority
              participant = AssignmentParticipant.find_by(id: params[:participant_id])
              assignment_id = SignUpTopic.find(params[:topic].first).assignment.id
              team_id = participant.team.try(:id)
              unless team_id
          Severity: Minor
          Found in app/controllers/sign_up_sheet_controller.rb - About 1 hr to fix

            Block has too many lines. [31/25]
            Open

                    %w[submission review].each do |deadline_type|
                      deadline_type_id = DeadlineType.find_by_name(deadline_type).id
                      next if instance_variable_get('@topic_' + deadline_type + '_due_date') == instance_variable_get('@assignment_' + deadline_type + '_due_date')
                      topic_due_date = TopicDueDate.where(parent_id: topic.id, deadline_type_id: deadline_type_id, round: i).first rescue nil
                      if topic_due_date.nil? # create a new record

            This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

            Method set_priority has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

              def set_priority
                participant = AssignmentParticipant.find_by(id: params[:participant_id])
                assignment_id = SignUpTopic.find(params[:topic].first).assignment.id
                team_id = participant.team.try(:id)
                unless team_id
            Severity: Minor
            Found in app/controllers/sign_up_sheet_controller.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method show_team has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              def show_team
                if !(assignment = Assignment.find(params[:assignment_id])).nil? and !(topic = SignUpTopic.find(params[:id])).nil?
                  @results = ad_info(assignment.id, topic.id)
                  @results.each do |result|
                    result.keys.each do |key|
            Severity: Minor
            Found in app/controllers/sign_up_sheet_controller.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method signup_as_instructor_action has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              def signup_as_instructor_action
                user = User.find_by(name: params[:username])
                if user.nil? # validate invalid user
                  flash[:error] = "That student does not exist!"
                else
            Severity: Minor
            Found in app/controllers/sign_up_sheet_controller.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Use find_by instead of dynamic find_by_name.
            Open

                      deadline_type_id = DeadlineType.find_by_name(deadline_type).id

            This cop checks dynamic find_by_* methods. Use find_by instead of dynamic method. See. https://github.com/bbatsov/rails-style-guide#find_by

            Example:

            # bad
            User.find_by_name(name)
            
            # bad
            User.find_by_name_and_email(name)
            
            # bad
            User.find_by_email!(name)
            
            # good
            User.find_by(name: name)
            
            # good
            User.find_by(name: name, email: email)
            
            # good
            User.find_by!(email: email)

            Avoid using update_attribute because it skips validations.
            Open

                  SignedUpTeam.where(team_id: team_id, is_waitlisted: 0).first.update_attribute('topic_id', params[:topic_id].to_i)

            This cop checks for the use of methods which skip validations which are listed in http://guides.rubyonrails.org/active_record_validations.html#skipping-validations

            Example:

            # bad
            Article.first.decrement!(:view_count)
            DiscussionBoard.decrement_counter(:post_count, 5)
            Article.first.increment!(:view_count)
            DiscussionBoard.increment_counter(:post_count, 5)
            person.toggle :active
            product.touch
            Billing.update_all("category = 'authorized', author = 'David'")
            user.update_attribute(website: 'example.com')
            user.update_columns(last_request_at: Time.current)
            Post.update_counters 5, comment_count: -1, action_count: 1
            
            # good
            user.update_attributes(website: 'example.com')
            FileUtils.touch('file')

            Avoid using update_all because it skips validations.
            Open

                      Bid.where(topic_id: topic_id, team_id: team_id).update_all(priority: index + 1)

            This cop checks for the use of methods which skip validations which are listed in http://guides.rubyonrails.org/active_record_validations.html#skipping-validations

            Example:

            # bad
            Article.first.decrement!(:view_count)
            DiscussionBoard.decrement_counter(:post_count, 5)
            Article.first.increment!(:view_count)
            DiscussionBoard.increment_counter(:post_count, 5)
            person.toggle :active
            product.touch
            Billing.update_all("category = 'authorized', author = 'David'")
            user.update_attribute(website: 'example.com')
            user.update_columns(last_request_at: Time.current)
            Post.update_counters 5, comment_count: -1, action_count: 1
            
            # good
            user.update_attributes(website: 'example.com')
            FileUtils.touch('file')

            Avoid using update_attribute because it skips validations.
            Open

                SignUpTopic.find(params[:topic_id]).update_attribute(:private_to, nil) if SignUpTopic.exists?(params[:topic_id])

            This cop checks for the use of methods which skip validations which are listed in http://guides.rubyonrails.org/active_record_validations.html#skipping-validations

            Example:

            # bad
            Article.first.decrement!(:view_count)
            DiscussionBoard.decrement_counter(:post_count, 5)
            Article.first.increment!(:view_count)
            DiscussionBoard.increment_counter(:post_count, 5)
            person.toggle :active
            product.touch
            Billing.update_all("category = 'authorized', author = 'David'")
            user.update_attribute(website: 'example.com')
            user.update_columns(last_request_at: Time.current)
            Post.update_counters 5, comment_count: -1, action_count: 1
            
            # good
            user.update_attributes(website: 'example.com')
            FileUtils.touch('file')

            Avoid using update_attribute because it skips validations.
            Open

                SignUpTopic.find(params[:topic_id]).update_attribute(:private_to, nil) if SignUpTopic.exists?(params[:topic_id])

            This cop checks for the use of methods which skip validations which are listed in http://guides.rubyonrails.org/active_record_validations.html#skipping-validations

            Example:

            # bad
            Article.first.decrement!(:view_count)
            DiscussionBoard.decrement_counter(:post_count, 5)
            Article.first.increment!(:view_count)
            DiscussionBoard.increment_counter(:post_count, 5)
            person.toggle :active
            product.touch
            Billing.update_all("category = 'authorized', author = 'David'")
            user.update_attribute(website: 'example.com')
            user.update_columns(last_request_at: Time.current)
            Post.update_counters 5, comment_count: -1, action_count: 1
            
            # good
            user.update_attributes(website: 'example.com')
            FileUtils.touch('file')

            Use each_key instead of keys.each.
            Open

                    result.keys.each do |key|

            This cop checks for uses of each_key and each_value Hash methods.

            Note: If you have an array of two-element arrays, you can put parentheses around the block arguments to indicate that you're not working with a hash, and suppress RuboCop offenses.

            Example:

            # bad
            hash.keys.each { |k| p k }
            hash.values.each { |v| p v }
            hash.each { |k, _v| p k }
            hash.each { |_k, v| p v }
            
            # good
            hash.each_key { |k| p k }
            hash.each_value { |v| p v }

            TODO found
            Open

                                       # TODO: fix this; cant use 0

            Omit parentheses for ternary conditions.
            Open

                  ((%w[list].include? action_name) ? are_needed_authorizations_present?(params[:id], "reader", "submitter", "reviewer") : true)

            This cop checks for the presence of parentheses around ternary conditions. It is configurable to enforce inclusion or omission of parentheses using EnforcedStyle. Omission is only enforced when removing the parentheses won't cause a different behavior.

            Example: EnforcedStyle: requirenoparentheses (default)

            # bad
            foo = (bar?) ? a : b
            foo = (bar.baz?) ? a : b
            foo = (bar && baz) ? a : b
            
            # good
            foo = bar? ? a : b
            foo = bar.baz? ? a : b
            foo = bar && baz ? a : b

            Example: EnforcedStyle: require_parentheses

            # bad
            foo = bar? ? a : b
            foo = bar.baz? ? a : b
            foo = bar && baz ? a : b
            
            # good
            foo = (bar?) ? a : b
            foo = (bar.baz?) ? a : b
            foo = (bar && baz) ? a : b

            Example: EnforcedStyle: requireparentheseswhen_complex

            # bad
            foo = (bar?) ? a : b
            foo = (bar.baz?) ? a : b
            foo = bar && baz ? a : b
            
            # good
            foo = bar? ? a : b
            foo = bar.baz? ? a : b
            foo = (bar && baz) ? a : b

            Convert if nested inside else to elsif.
            Open

                  if AssignmentParticipant.exists? user_id: user.id, parent_id: params[:assignment_id]

            If the else branch of a conditional consists solely of an if node, it can be combined with the else to become an elsif. This helps to keep the nesting level from getting too deep.

            Example:

            # bad
            if condition_a
              action_a
            else
              if condition_b
                action_b
              else
                action_c
              end
            end
            
            # good
            if condition_a
              action_a
            elsif condition_b
              action_b
            else
              action_c
            end

            Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead.
            Open

                elsif !drop_topic_deadline.nil? and Time.now > drop_topic_deadline.due_at

            This cop checks for the use of Time methods without zone.

            Built on top of Ruby on Rails style guide (https://github.com/bbatsov/rails-style-guide#time) and the article http://danilenko.org/2012/7/6/rails_timezones/ .

            Two styles are supported for this cop. When EnforcedStyle is 'strict' then only use of Time.zone is allowed.

            When EnforcedStyle is 'flexible' then it's also allowed to use Time.intimezone.

            Example:

            # always offense
            Time.now
            Time.parse('2015-03-02 19:05:37')
            
            # no offense
            Time.zone.now
            Time.zone.parse('2015-03-02 19:05:37')
            
            # no offense only if style is 'flexible'
            Time.current
            DateTime.strptime(str, "%Y-%m-%d %H:%M %Z").in_time_zone
            Time.at(timestamp).in_time_zone

            Useless assignment to variable - assignment.
            Open

                assignment = Assignment.find(assignment_id)

            This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

            assigned but unused variable - foo

            Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

            Example:

            # bad
            
            def some_method
              some_var = 1
              do_something
            end

            Example:

            # good
            
            def some_method
              some_var = 1
              do_something(some_var)
            end

            Line is too long. [161/160]
            Open

                when 'set_priority', 'sign_up', 'delete_signup', 'list', 'show_team', 'switch_original_topic_to_approved_suggested_topic', 'publish_approved_suggested_topic'

            Prefer Date or Time over DateTime.
            Open

                    @assignment_submission_due_date = DateTime.parse(@assignment_submission_due_dates[i - 1].due_at.to_s).strftime("%Y-%m-%d %H:%M")

            This cop checks for uses of DateTime that should be replaced by Date or Time.

            Example:

            # bad - uses `DateTime` for current time
            DateTime.now
            
            # good - uses `Time` for current time
            Time.now
            
            # bad - uses `DateTime` for modern date
            DateTime.iso8601('2016-06-29')
            
            # good - uses `Date` for modern date
            Date.iso8601('2016-06-29')
            
            # good - uses `DateTime` with start argument for historical date
            DateTime.iso8601('1751-04-23', Date::ENGLAND)

            Use snake_case for variable names.
            Open

                  resultMap = {}

            This cop makes sure that all variables use the configured style, snake_case or camelCase, for their names.

            Example: EnforcedStyle: snake_case (default)

            # bad
            fooBar = 1
            
            # good
            foo_bar = 1

            Example: EnforcedStyle: camelCase

            # bad
            foo_bar = 1
            
            # good
            fooBar = 1

            Use a guard clause instead of wrapping the code inside a conditional expression.
            Open

                if !(assignment = Assignment.find(params[:assignment_id])).nil? and !(topic = SignUpTopic.find(params[:id])).nil?

            Use a guard clause instead of wrapping the code inside a conditional expression

            Example:

            # bad
            def test
              if something
                work
              end
            end
            
            # good
            def test
              return unless something
              work
            end
            
            # also good
            def test
              work if something
            end
            
            # bad
            if something
              raise 'exception'
            else
              ok
            end
            
            # good
            raise 'exception' if something
            ok

            Convert if nested inside else to elsif.
            Open

                  if topic.max_choosers.to_i < params[:topic][:max_choosers].to_i

            If the else branch of a conditional consists solely of an if node, it can be combined with the else to become an elsif. This helps to keep the nesting level from getting too deep.

            Example:

            # bad
            if condition_a
              action_a
            else
              if condition_b
                action_b
              else
                action_c
              end
            end
            
            # good
            if condition_a
              action_a
            elsif condition_b
              action_b
            else
              action_c
            end

            Do not use DateTime.parse.strftime without zone. Use one of Time.zone.parse.strftime, DateTime.current, DateTime.parse.strftime.in_time_zone, DateTime.parse.strftime.utc, DateTime.parse.strftime.getlocal, DateTime.parse.strftime.iso8601, DateTime.parse.strftime.jisx0301, DateTime.parse.strftime.rfc3339, DateTime.parse.strftime.to_i, DateTime.parse.strftime.to_f instead.
            Open

                    @assignment_submission_due_date = DateTime.parse(@assignment_submission_due_dates[i - 1].due_at.to_s).strftime("%Y-%m-%d %H:%M")

            This cop checks for the use of Time methods without zone.

            Built on top of Ruby on Rails style guide (https://github.com/bbatsov/rails-style-guide#time) and the article http://danilenko.org/2012/7/6/rails_timezones/ .

            Two styles are supported for this cop. When EnforcedStyle is 'strict' then only use of Time.zone is allowed.

            When EnforcedStyle is 'flexible' then it's also allowed to use Time.intimezone.

            Example:

            # always offense
            Time.now
            Time.parse('2015-03-02 19:05:37')
            
            # no offense
            Time.zone.now
            Time.zone.parse('2015-03-02 19:05:37')
            
            # no offense only if style is 'flexible'
            Time.current
            DateTime.strptime(str, "%Y-%m-%d %H:%M %Z").in_time_zone
            Time.at(timestamp).in_time_zone

            Useless assignment to variable - topic_set. Did you mean topic?
            Open

                  topic_set = []

            This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

            assigned but unused variable - foo

            Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

            Example:

            # bad
            
            def some_method
              some_var = 1
              do_something
            end

            Example:

            # good
            
            def some_method
              some_var = 1
              do_something(some_var)
            end

            Useless assignment to variable - topic. Did you mean topic_set?
            Open

                  topic = @sign_up_topic.id

            This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

            assigned but unused variable - foo

            Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

            Example:

            # bad
            
            def some_method
              some_var = 1
              do_something
            end

            Example:

            # good
            
            def some_method
              some_var = 1
              do_something(some_var)
            end

            Prefer each over for.
            Open

                  for i in 1..review_rounds

            This cop looks for uses of the for keyword, or each method. The preferred alternative is set in the EnforcedStyle configuration parameter. An each call with a block on a single line is always allowed, however.

            Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead.
            Open

                  @show_actions = false if !@assignment.staggered_deadline? and @assignment.due_dates.find_by(deadline_type_id: 1).due_at < Time.now

            This cop checks for the use of Time methods without zone.

            Built on top of Ruby on Rails style guide (https://github.com/bbatsov/rails-style-guide#time) and the article http://danilenko.org/2012/7/6/rails_timezones/ .

            Two styles are supported for this cop. When EnforcedStyle is 'strict' then only use of Time.zone is allowed.

            When EnforcedStyle is 'flexible' then it's also allowed to use Time.intimezone.

            Example:

            # always offense
            Time.now
            Time.parse('2015-03-02 19:05:37')
            
            # no offense
            Time.zone.now
            Time.zone.parse('2015-03-02 19:05:37')
            
            # no offense only if style is 'flexible'
            Time.current
            DateTime.strptime(str, "%Y-%m-%d %H:%M %Z").in_time_zone
            Time.at(timestamp).in_time_zone

            Do not use DateTime.parse.strftime without zone. Use one of Time.zone.parse.strftime, DateTime.current, DateTime.parse.strftime.in_time_zone, DateTime.parse.strftime.utc, DateTime.parse.strftime.getlocal, DateTime.parse.strftime.iso8601, DateTime.parse.strftime.jisx0301, DateTime.parse.strftime.rfc3339, DateTime.parse.strftime.to_i, DateTime.parse.strftime.to_f instead.
            Open

                    @assignment_review_due_date = DateTime.parse(@assignment_review_due_dates[i - 1].due_at.to_s).strftime("%Y-%m-%d %H:%M")

            This cop checks for the use of Time methods without zone.

            Built on top of Ruby on Rails style guide (https://github.com/bbatsov/rails-style-guide#time) and the article http://danilenko.org/2012/7/6/rails_timezones/ .

            Two styles are supported for this cop. When EnforcedStyle is 'strict' then only use of Time.zone is allowed.

            When EnforcedStyle is 'flexible' then it's also allowed to use Time.intimezone.

            Example:

            # always offense
            Time.now
            Time.parse('2015-03-02 19:05:37')
            
            # no offense
            Time.zone.now
            Time.zone.parse('2015-03-02 19:05:37')
            
            # no offense only if style is 'flexible'
            Time.current
            DateTime.strptime(str, "%Y-%m-%d %H:%M %Z").in_time_zone
            Time.at(timestamp).in_time_zone

            Line is too long. [177/160]
            Open

                assignment.staggered_deadline == true ? (redirect_to action: 'add_signup_topics_staggered', id: assignment_id) : (redirect_to action: 'add_signup_topics', id: assignment_id)

            Prefer Date or Time over DateTime.
            Open

                    @assignment_review_due_date = DateTime.parse(@assignment_review_due_dates[i - 1].due_at.to_s).strftime("%Y-%m-%d %H:%M")

            This cop checks for uses of DateTime that should be replaced by Date or Time.

            Example:

            # bad - uses `DateTime` for current time
            DateTime.now
            
            # good - uses `Time` for current time
            Time.now
            
            # bad - uses `DateTime` for modern date
            DateTime.iso8601('2016-06-29')
            
            # good - uses `Date` for modern date
            Date.iso8601('2016-06-29')
            
            # good - uses `DateTime` with start argument for historical date
            DateTime.iso8601('1751-04-23', Date::ENGLAND)

            Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead.
            Open

                elsif !drop_topic_deadline.nil? and Time.now > drop_topic_deadline.due_at

            This cop checks for the use of Time methods without zone.

            Built on top of Ruby on Rails style guide (https://github.com/bbatsov/rails-style-guide#time) and the article http://danilenko.org/2012/7/6/rails_timezones/ .

            Two styles are supported for this cop. When EnforcedStyle is 'strict' then only use of Time.zone is allowed.

            When EnforcedStyle is 'flexible' then it's also allowed to use Time.intimezone.

            Example:

            # always offense
            Time.now
            Time.parse('2015-03-02 19:05:37')
            
            # no offense
            Time.zone.now
            Time.zone.parse('2015-03-02 19:05:37')
            
            # no offense only if style is 'flexible'
            Time.current
            DateTime.strptime(str, "%Y-%m-%d %H:%M %Z").in_time_zone
            Time.at(timestamp).in_time_zone

            There are no issues that match your filters.

            Category
            Status