Sign upLogin

expertiza/expertiza

View on GitHub
Star
app/models/criterion.rb

Summary

Maintainability
C
1 day
Test Coverage
F
8%

Class has too many lines. [148/100]
Open

class Criterion < ScoredQuestion
  include ActionView::Helpers
  validates :size, presence: true

  # This method returns what to display if an instructor (etc.) is creating or editing a questionnaire (questionnaires_controller.rb)
Severity: Minor
Found in app/models/criterion.rb by rubocop

This cop checks if the length a class exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for edit is too high. [90.14/15]
Open

  def edit(_count)
    html = '<td align="center"><a rel="nofollow" data-method="delete" href="/questions/' + id.to_s + '">Remove</a></td>'

    html += '<td><input size="6" value="' + seq.to_s + '" name="question[' + id.to_s + '][seq]"'
    html += ' id="question_' + id.to_s + '_seq" type="text"></td>'
Severity: Minor
Found in app/models/criterion.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Assignment Branch Condition size for scale_criterion_question is too high. [86.18/15]
Open

  def scale_criterion_question(count, answer = nil, questionnaire_min, questionnaire_max)
    if size.nil? || size.blank?
      cols = '70'
      rows = '1'
    else
Severity: Minor
Found in app/models/criterion.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Assignment Branch Condition size for view_completed_question is too high. [59.74/15]
Open

  def view_completed_question(count, answer, questionnaire_max, tag_prompt_deployments = nil, current_user = nil)
    html = '<b>' + count.to_s + '. ' + txt + ' [Max points: ' + questionnaire_max.to_s + ']</b>'
    score = answer && !answer.answer.nil? ? answer.answer.to_s : '-'
    score_percent = score != '-' ? answer.answer * 1.0 / questionnaire_max : 0
    score_color = if score_percent > 0.8
Severity: Minor
Found in app/models/criterion.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Assignment Branch Condition size for dropdown_criterion_question is too high. [52.74/15]
Open

  def dropdown_criterion_question(count, answer = nil, questionnaire_min, questionnaire_max)
    current_value = ''
    current_value += 'data-current-rating =' + answer.answer.to_s unless answer.nil?
    html = '<div><select id="responses_' + count.to_s + '_score" name="responses[' + count.to_s + '][score]" class="review-rating" ' + current_value + '>'
    html += "<option value = ''>--</option>"
Severity: Minor
Found in app/models/criterion.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Assignment Branch Condition size for advices_criterion_question is too high. [44.65/15]
Open

  def advices_criterion_question(count, question_advices)
    html = '<a id="showAdvice_' + id.to_s + '" onclick="showAdvice(' + id.to_s + ')">Show advice</a><script>'
    html += 'function showAdvice(i){var element = document.getElementById("showAdvice_" + i.toString());'
    html += 'var show = element.innerHTML == "Hide advice";'
    html += 'if (show){element.innerHTML="Show advice";} else{element.innerHTML="Hide advice";}toggleAdvice(i);}'
Severity: Minor
Found in app/models/criterion.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Assignment Branch Condition size for view_question_text is too high. [43.73/15]
Open

  def view_question_text
    html = '<TD align="left"> ' + txt + ' </TD>'
    html += '<TD align="left">' + type + '</TD>'
    html += '<td align="center">' + weight.to_s + '</TD>'
    questionnaire = self.questionnaire
Severity: Minor
Found in app/models/criterion.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [34/10]
Open

  def view_completed_question(count, answer, questionnaire_max, tag_prompt_deployments = nil, current_user = nil)
    html = '<b>' + count.to_s + '. ' + txt + ' [Max points: ' + questionnaire_max.to_s + ']</b>'
    score = answer && !answer.answer.nil? ? answer.answer.to_s : '-'
    score_percent = score != '-' ? answer.answer * 1.0 / questionnaire_max : 0
    score_color = if score_percent > 0.8
Severity: Minor
Found in app/models/criterion.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [31/10]
Open

  def scale_criterion_question(count, answer = nil, questionnaire_min, questionnaire_max)
    if size.nil? || size.blank?
      cols = '70'
      rows = '1'
    else
Severity: Minor
Found in app/models/criterion.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for complete is too high. [29.77/15]
Open

  def complete(count, answer = nil, questionnaire_min, questionnaire_max, dropdown_or_scale)
    html = '<div><label for="responses_' + count.to_s + '">' + txt + '</label></div>'
    question_advices = QuestionAdvice.where(question_id: id).sort_by(&:id)
    advice_total_length = 0
    question_advices.each do |question_advice|
Severity: Minor
Found in app/models/criterion.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Cyclomatic complexity for view_completed_question is too high. [14/6]
Open

  def view_completed_question(count, answer, questionnaire_max, tag_prompt_deployments = nil, current_user = nil)
    html = '<b>' + count.to_s + '. ' + txt + ' [Max points: ' + questionnaire_max.to_s + ']</b>'
    score = answer && !answer.answer.nil? ? answer.answer.to_s : '-'
    score_percent = score != '-' ? answer.answer * 1.0 / questionnaire_max : 0
    score_color = if score_percent > 0.8
Severity: Minor
Found in app/models/criterion.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Perceived complexity for view_completed_question is too high. [15/7]
Open

  def view_completed_question(count, answer, questionnaire_max, tag_prompt_deployments = nil, current_user = nil)
    html = '<b>' + count.to_s + '. ' + txt + ' [Max points: ' + questionnaire_max.to_s + ']</b>'
    score = answer && !answer.answer.nil? ? answer.answer.to_s : '-'
    score_percent = score != '-' ? answer.answer * 1.0 / questionnaire_max : 0
    score_color = if score_percent > 0.8
Severity: Minor
Found in app/models/criterion.rb by rubocop

This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Cyclomatic complexity for scale_criterion_question is too high. [12/6]
Open

  def scale_criterion_question(count, answer = nil, questionnaire_min, questionnaire_max)
    if size.nil? || size.blank?
      cols = '70'
      rows = '1'
    else
Severity: Minor
Found in app/models/criterion.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Perceived complexity for scale_criterion_question is too high. [13/7]
Open

  def scale_criterion_question(count, answer = nil, questionnaire_min, questionnaire_max)
    if size.nil? || size.blank?
      cols = '70'
      rows = '1'
    else
Severity: Minor
Found in app/models/criterion.rb by rubocop

This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Method has too many lines. [16/10]
Open

  def dropdown_criterion_question(count, answer = nil, questionnaire_min, questionnaire_max)
    current_value = ''
    current_value += 'data-current-rating =' + answer.answer.to_s unless answer.nil?
    html = '<div><select id="responses_' + count.to_s + '_score" name="responses[' + count.to_s + '][score]" class="review-rating" ' + current_value + '>'
    html += "<option value = ''>--</option>"
Severity: Minor
Found in app/models/criterion.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method view_completed_question has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

  def view_completed_question(count, answer, questionnaire_max, tag_prompt_deployments = nil, current_user = nil)
    html = '<b>' + count.to_s + '. ' + txt + ' [Max points: ' + questionnaire_max.to_s + ']</b>'
    score = answer && !answer.answer.nil? ? answer.answer.to_s : '-'
    score_percent = score != '-' ? answer.answer * 1.0 / questionnaire_max : 0
    score_color = if score_percent > 0.8
Severity: Minor
Found in app/models/criterion.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method has too many lines. [15/10]
Open

  def advices_criterion_question(count, question_advices)
    html = '<a id="showAdvice_' + id.to_s + '" onclick="showAdvice(' + id.to_s + ')">Show advice</a><script>'
    html += 'function showAdvice(i){var element = document.getElementById("showAdvice_" + i.toString());'
    html += 'var show = element.innerHTML == "Hide advice";'
    html += 'if (show){element.innerHTML="Show advice";} else{element.innerHTML="Hide advice";}toggleAdvice(i);}'
Severity: Minor
Found in app/models/criterion.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [15/10]
Open

  def edit(_count)
    html = '<td align="center"><a rel="nofollow" data-method="delete" href="/questions/' + id.to_s + '">Remove</a></td>'

    html += '<td><input size="6" value="' + seq.to_s + '" name="question[' + id.to_s + '][seq]"'
    html += ' id="question_' + id.to_s + '_seq" type="text"></td>'
Severity: Minor
Found in app/models/criterion.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Cyclomatic complexity for dropdown_criterion_question is too high. [10/6]
Open

  def dropdown_criterion_question(count, answer = nil, questionnaire_min, questionnaire_max)
    current_value = ''
    current_value += 'data-current-rating =' + answer.answer.to_s unless answer.nil?
    html = '<div><select id="responses_' + count.to_s + '_score" name="responses[' + count.to_s + '][score]" class="review-rating" ' + current_value + '>'
    html += "<option value = ''>--</option>"
Severity: Minor
Found in app/models/criterion.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Perceived complexity for dropdown_criterion_question is too high. [10/7]
Open

  def dropdown_criterion_question(count, answer = nil, questionnaire_min, questionnaire_max)
    current_value = ''
    current_value += 'data-current-rating =' + answer.answer.to_s unless answer.nil?
    html = '<div><select id="responses_' + count.to_s + '_score" name="responses[' + count.to_s + '][score]" class="review-rating" ' + current_value + '>'
    html += "<option value = ''>--</option>"
Severity: Minor
Found in app/models/criterion.rb by rubocop

This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Method scale_criterion_question has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

  def scale_criterion_question(count, answer = nil, questionnaire_min, questionnaire_max)
    if size.nil? || size.blank?
      cols = '70'
      rows = '1'
    else
Severity: Minor
Found in app/models/criterion.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method has too many lines. [11/10]
Open

  def view_question_text
    html = '<TD align="left"> ' + txt + ' </TD>'
    html += '<TD align="left">' + type + '</TD>'
    html += '<td align="center">' + weight.to_s + '</TD>'
    questionnaire = self.questionnaire
Severity: Minor
Found in app/models/criterion.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Cyclomatic complexity for complete is too high. [7/6]
Open

  def complete(count, answer = nil, questionnaire_min, questionnaire_max, dropdown_or_scale)
    html = '<div><label for="responses_' + count.to_s + '">' + txt + '</label></div>'
    question_advices = QuestionAdvice.where(question_id: id).sort_by(&:id)
    advice_total_length = 0
    question_advices.each do |question_advice|
Severity: Minor
Found in app/models/criterion.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method view_completed_question has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def view_completed_question(count, answer, questionnaire_max, tag_prompt_deployments = nil, current_user = nil)
    html = '<b>' + count.to_s + '. ' + txt + ' [Max points: ' + questionnaire_max.to_s + ']</b>'
    score = answer && !answer.answer.nil? ? answer.answer.to_s : '-'
    score_percent = score != '-' ? answer.answer * 1.0 / questionnaire_max : 0
    score_color = if score_percent > 0.8
Severity: Minor
Found in app/models/criterion.rb - About 1 hr to fix

    Method scale_criterion_question has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def scale_criterion_question(count, answer = nil, questionnaire_min, questionnaire_max)
    if size.nil? || size.blank?
      cols = '70'
      rows = '1'
    else
    Severity: Minor
    Found in app/models/criterion.rb - About 1 hr to fix

      Method dropdown_criterion_question has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        def dropdown_criterion_question(count, answer = nil, questionnaire_min, questionnaire_max)
    current_value = ''
    current_value += 'data-current-rating =' + answer.answer.to_s unless answer.nil?
    html = '<div><select id="responses_' + count.to_s + '_score" name="responses[' + count.to_s + '][score]" class="review-rating" ' + current_value + '>'
    html += "<option value = ''>--</option>"
      Severity: Minor
      Found in app/models/criterion.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method complete has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def complete(count, answer = nil, questionnaire_min, questionnaire_max, dropdown_or_scale)
      Severity: Minor
      Found in app/models/criterion.rb - About 35 mins to fix

        Method view_completed_question has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          def view_completed_question(count, answer, questionnaire_max, tag_prompt_deployments = nil, current_user = nil)
        Severity: Minor
        Found in app/models/criterion.rb - About 35 mins to fix

          Method complete has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def complete(count, answer = nil, questionnaire_min, questionnaire_max, dropdown_or_scale)
    html = '<div><label for="responses_' + count.to_s + '">' + txt + '</label></div>'
    question_advices = QuestionAdvice.where(question_id: id).sort_by(&:id)
    advice_total_length = 0
    question_advices.each do |question_advice|
          Severity: Minor
          Found in app/models/criterion.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Optional arguments should appear at the end of the argument list.
          Open

            def complete(count, answer = nil, questionnaire_min, questionnaire_max, dropdown_or_scale)
          Severity: Minor
          Found in app/models/criterion.rb by rubocop

          This cop checks for optional arguments to methods that do not come at the end of the argument list

          Example:

          # bad
def foo(a = 1, b, c)
end

# good
def baz(a, b, c = 1)
end

def foobar(a = 1, b = 2, c = 3)
end

          Optional arguments should appear at the end of the argument list.
          Open

            def dropdown_criterion_question(count, answer = nil, questionnaire_min, questionnaire_max)
          Severity: Minor
          Found in app/models/criterion.rb by rubocop

          This cop checks for optional arguments to methods that do not come at the end of the argument list

          Example:

          # bad
def foo(a = 1, b, c)
end

# good
def baz(a, b, c = 1)
end

def foobar(a = 1, b = 2, c = 3)
end

          Optional arguments should appear at the end of the argument list.
          Open

            def scale_criterion_question(count, answer = nil, questionnaire_min, questionnaire_max)
          Severity: Minor
          Found in app/models/criterion.rb by rubocop

          This cop checks for optional arguments to methods that do not come at the end of the argument list

          Example:

          # bad
def foo(a = 1, b, c)
end

# good
def baz(a, b, c = 1)
end

def foobar(a = 1, b = 2, c = 3)
end

          There are no issues that match your filters.

          Category
          Status