expertiza/expertiza

Block has too many lines. [401/25]

Open

describe QuestionnairesController do
  let(:questionnaire) do
    build(id: 1, name: 'questionnaire', ta_id: 8, course_id: 1, private: false, min_question_score: 0, max_question_score: 5, type: 'ReviewQuestionnaire')
  end
  let(:questionnaire) { build(:questionnaire) }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

File questionnaires_controller_spec.rb has 403 lines of code (exceeds 250 allowed). Consider refactoring.

Open

describe QuestionnairesController do
  let(:questionnaire) do
    build(id: 1, name: 'questionnaire', ta_id: 8, course_id: 1, private: false, min_question_score: 0, max_question_score: 5, type: 'ReviewQuestionnaire')
  end
  let(:questionnaire) { build(:questionnaire) }

Block has too many lines. [72/25]

Open

  describe '#update' do
    before(:each) do
      @questionnaire1 = double('Questionnaire', id: 1)
      allow(Questionnaire).to receive(:find).with('1').and_return(@questionnaire1)
      @request_params = { id: 1,

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Block has too many lines. [61/25]

Open

  describe '#action_allowed?' do
    let(:questionnaire) { build(:questionnaire, id: 1) }
    let(:instructor) { build(:instructor, id: 1) }
    let(:ta) { build(:teaching_assistant, id: 10, parent_id: 66) }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Block has too many lines. [49/25]

Open

  describe '#delete' do
    context 'when @questionnaire.assignments returns non-empty array' do
      it 'sends the error message to flash[:error]' do
        questionnaire1 = double('Questionnaire',
                                name: 'test questionnaire',

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Block has too many lines. [48/25]

Open

  describe '#add_new_questions' do
    let(:criterion) { Criterion.new(id: 2, weight: 1, max_label: '', min_label: '', size: '', alternatives: '') }
    let(:dropdown) { Dropdown.new(id: 3, size: '', alternatives: '') }

    context 'when adding ScoredQuestion' do

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Block has too many lines. [46/25]

Open

    context 'when request_params action is edit or update' do
      before(:each) do
        controller.params = { id: '1', action: 'edit' }
        controller.request.session[:user] = instructor
      end

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Block has too many lines. [28/25]

Open

  describe '#new' do
    context 'when request_params[:model] has whitespace in it' do
      it 'creates new questionnaire object and renders questionnaires#new page' do
        request_params = { model: 'Assignment SurveyQuestionnaire' }
        get :new, params: request_params

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Block has too many lines. [26/25]

Open

    before(:each) do
      @questionnaire1 = double('Questionnaire', id: 1)
      allow(Questionnaire).to receive(:find).with('1').and_return(@questionnaire1)
      @request_params = { id: 1,
                          questionnaire: { name: 'test questionnaire',

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Block has too many lines. [26/25]

Open

  describe '#save_all_questions' do
    context 'when request_params[:save] is not nil, params: request_params[:view_advice] is nil' do
      it 'redirects to questionnaires#edit page after saving all questions' do
        allow(Question).to receive(:find).with('1').and_return(question)
        allow(question).to receive(:save).and_return(true)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    context 'when @questionnaire is not nil' do
      it 'renders the questionnaires#edit page' do
        allow(Questionnaire).to receive(:find).with('1').and_return(double('Questionnaire', instructor_id: 6))
        user_session = { user: instructor }
        request_params = { id: 1 }

• Read up
  Read up

Useless assignment to variable - instructor1. Did you mean instructor2?

Open

          instructor1 = create(:instructor, name: 'test_instructor1')

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

assigned but unused variable - foo

# bad

def some_method
  some_var = 1
  do_something
end

# good

def some_method
  some_var = 1
  do_something(some_var)
end