expertiza/expertiza

View on GitHub
spec/helpers/sign_up_sheet_helper_spec.rb

Summary

Maintainability
A
1 hr
Test Coverage

Block has too many lines. [91/25]
Open

describe 'SignUpSheetHelper' do
  describe '#check_topic_due_date_value' do
    before(:each) do
      @assignment = create(:assignment)
      @topic = create(:topic, assignment: @assignment)

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Block has too many lines. [26/25]
Open

  describe '#get_intelligent_topic_row' do
    before(:each) do
      @assignment = create(:assignment)
      @topic1 = create(:topic, topic_name: 'Topic 1', assignment: @assignment)
      @topic2 = create(:topic, topic_name: 'Topic 2', assignment: @assignment)

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    before(:each) do
      @assignment1 = create(:assignment, name: 'final 1', directory_path: 'final_1')
      @topic1 = create(:topic, assignment: @assignment1)
      @assignment2 = create(:assignment, name: 'final 2', directory_path: 'final_2')
      @topic2 = create(:topic, assignment: @assignment2)
Severity: Minor
Found in spec/helpers/sign_up_sheet_helper_spec.rb and 1 other location - About 40 mins to fix
spec/helpers/sign_up_sheet_helper_spec.rb on lines 72..77

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    before(:each) do
      @assignment1 = create(:assignment, name: 'final 1', directory_path: 'final_1')
      @topic1 = create(:topic, assignment: @assignment1)
      @assignment2 = create(:assignment, name: 'final 2', directory_path: 'final_2')
      @topic2 = create(:topic, assignment: @assignment2)
Severity: Minor
Found in spec/helpers/sign_up_sheet_helper_spec.rb and 1 other location - About 40 mins to fix
spec/helpers/sign_up_sheet_helper_spec.rb on lines 91..96

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Extra empty line detected at block body end.
Open


end

This cops checks if empty lines around the bodies of blocks match the configuration.

Example: EnforcedStyle: empty_lines

# good

foo do |bar|

  # ...

end

Example: EnforcedStyle: noemptylines (default)

# good

foo do |bar|
  # ...
end

Trailing whitespace detected.
Open

  end  

There are no issues that match your filters.

Category
Status