Sign upLogin

expertiza/expertiza

View on GitHub
Star
spec/models/response_spec.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Block has too many lines. [327/25]
Open

describe Response do
  let(:user) { build(:student, id: 1, role_id: 1, name: 'no name', fullname: 'no one') }
  let(:user2) { build(:student, id: 2, role_id: 2, name: 'no name2', fullname: 'no one2') }
  let(:participant) { build(:participant, id: 1, parent_id: 1, user: user) }
  let(:participant2) { build(:participant, id: 2, parent_id: 2, user: user2) }
Severity: Minor
Found in spec/models/response_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

File response_spec.rb has 329 lines of code (exceeds 250 allowed). Consider refactoring.
Open

describe Response do
  let(:user) { build(:student, id: 1, role_id: 1, name: 'no name', fullname: 'no one') }
  let(:user2) { build(:student, id: 2, role_id: 2, name: 'no name2', fullname: 'no one2') }
  let(:participant) { build(:participant, id: 1, parent_id: 1, user: user) }
  let(:participant2) { build(:participant, id: 2, parent_id: 2, user: user2) }
Severity: Minor
Found in spec/models/response_spec.rb - About 3 hrs to fix

    Block has too many lines. [40/25]
    Open

      describe '#display_as_html' do
    before(:each) do
      allow(Answer).to receive(:where).with(response_id: 1).and_return([answer])
    end
    Severity: Minor
    Found in spec/models/response_spec.rb by rubocop

    This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

    Block has too many lines. [29/25]
    Open

      describe '#questionnaire_by_answer' do
    before(:each) do
      allow(SignedUpTeam).to receive(:find_by).with(team_id: team.id).and_return(signed_up_team)
    end
    context 'when answer is not nil' do
    Severity: Minor
    Found in spec/models/response_spec.rb by rubocop

    This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

    Block has too many lines. [27/25]
    Open

      describe 'notify_instructor_on_difference' do
    it 'should send correct data format' do
      allow(AssignmentParticipant).to receive(:find).with(1).and_return(participant)
      allow(User).to receive(:find).with(1).and_return(user)
      team = double('AssignmentTeam', participants: [participant2])
    Severity: Minor
    Found in spec/models/response_spec.rb by rubocop

    This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        it 'true if review is done by teaching assistant' do
      allow(Response).to receive(:find).with(1).and_return(response)
      allow(ResponseMap).to receive(:find).with(1).and_return(review_response_map)
      allow(Participant).to receive(:find).with(1).and_return(participant)
      allow(User).to receive(:find).with(1).and_return(user)
    Severity: Major
    Found in spec/models/response_spec.rb and 1 other location - About 1 hr to fix
    spec/models/response_spec.rb on lines 331..337

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        it 'true if review is done by Instructor' do
      allow(Response).to receive(:find).with(1).and_return(response)
      allow(ResponseMap).to receive(:find).with(1).and_return(review_response_map)
      allow(Participant).to receive(:find).with(1).and_return(participant)
      allow(User).to receive(:find).with(1).and_return(user)
    Severity: Major
    Found in spec/models/response_spec.rb and 1 other location - About 1 hr to fix
    spec/models/response_spec.rb on lines 340..346

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status