express42-cookbooks/postgresql_lwrp

View on GitHub

Showing 7 of 16 total issues

Method install_wal_e has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def install_wal_e
    wal_e_attributes = node['postgresql']['cloud_backup']['wal_e']

    python_runtime '3' do
      provider :system
Severity: Minor
Found in resources/cloud_backup.rb - About 1 hr to fix

    Method install_extension has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

          def install_extension(cluster_version, cluster_name, cluster_database, extension, options)
            raise "extension '#{extension}' is not available, please use \'pgxn_extension\' resource to install the extention" unless extension_available?(cluster_version, cluster_name, extension)
    
            stdout, stderr = exec_in_pg_cluster(cluster_version, cluster_name, cluster_database, 'SELECT extname FROM pg_extension')
            raise "postgresql install_extension: can't get extensions list\nSTDOUT: #{stdout}\nSTDERR: #{stderr}" unless stderr.empty?
    Severity: Minor
    Found in libraries/helpers.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method install_extension has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def install_extension(cluster_version, cluster_name, cluster_database, extension, options)
    Severity: Minor
    Found in libraries/helpers.rb - About 35 mins to fix

      Method create_user has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def create_user(cluster_version, cluster_name, cluster_user, options)
              stdout, stderr = exec_in_pg_cluster(cluster_version, cluster_name, 'SELECT usename FROM pg_user')
              raise "postgresql create_user: can't get users list\nSTDOUT: #{stdout}\nSTDERR: #{stderr}" unless stderr.empty?
      
              if stdout.include? cluster_user
      Severity: Minor
      Found in libraries/helpers.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method pgxn_install_extension has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def pgxn_install_extension(cluster_version, cluster_name, params, options)
              pgxn_status = Mixlib::ShellOut.new("pgxn install '#{params[:name]}'='#{params[:version]}' --sudo --#{params[:stage]}")
              pgxn_status.run_command
      
              stdout, stderr = exec_in_pg_cluster(cluster_version, cluster_name, params[:db], 'SELECT extname FROM pg_extension')
      Severity: Minor
      Found in libraries/helpers.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method create_database has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def create_database(cluster_version, cluster_name, cluster_database, options)
              stdout, stderr = exec_in_pg_cluster(cluster_version, cluster_name, 'SELECT datname FROM pg_database')
              raise "postgresql create_database: can't get database list\nSTDOUT: #{stdout}\nSTDERR: #{stderr}" unless stderr.empty?
      
              if stdout.gsub(/\s+/, ' ').split(' ').include? cluster_database
      Severity: Minor
      Found in libraries/helpers.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method configuration_hacks has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def configuration_hacks(configuration, cluster_version)
              configuration['unix_socket_directory'] ||= '/var/run/postgresql' if cluster_version.to_f < 9.3
              configuration['unix_socket_directories'] ||= '/var/run/postgresql' if cluster_version.to_f >= 9.3
              configuration.delete('wal_receiver_status_interval') if cluster_version.to_f < 9.1
              configuration.delete('hot_standby_feedback') if cluster_version.to_f < 9.1
      Severity: Minor
      Found in libraries/helpers.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language