exxamalte/python-geojson-client

View on GitHub

Showing 5 of 5 total issues

File __init__.py has 265 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""
Base class for GeoJSON services.

Fetches GeoJSON feed from URL to be defined by sub-class.
"""
Severity: Minor
Found in geojson_client/__init__.py - About 2 hrs to fix

    Function _update_internal has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def _update_internal(
            self, filter_function: Callable[[List], List]
        ) -> Tuple[str, Optional[List]]:
            """Update from external source and return filtered entries."""
            status, data = self._fetch()
    Severity: Minor
    Found in geojson_client/__init__.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function extract_coordinates has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def extract_coordinates(geometry):
            """Extract the best coordinates from the feature for display."""
            latitude = longitude = None
            if isinstance(geometry, Point):
                # Just extract latitude and longitude directly.
    Severity: Minor
    Found in geojson_client/__init__.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __init__ has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(
    Severity: Major
    Found in geojson_client/usgs_earthquake_hazards_program_feed.py - About 50 mins to fix

      Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def __init__(
      Severity: Minor
      Found in geojson_client/generic_feed.py - About 45 mins to fix
        Severity
        Category
        Status
        Source
        Language