Function processResult
has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring. Open
private function processResult(string $query, $result = null, bool $isSelect = false)
{
$this->shortcutUsed = false;
// If there is an error then take note of it..
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File ez_pdo.php
has 297 lines of code (exceeds 250 allowed). Consider refactoring. Wontfix
<?php
declare(strict_types=1);
namespace ezsql\Database;
Function processQuery
has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring. Open
private function processQuery(string $query, array $param = null)
{
// Query was an insert, delete, update, replace
if (\preg_match("/^(insert|delete|update|replace|drop|create)\s+/i", $query)) {
// Perform the query and log number of affected rows
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method connect
has 45 lines of code (exceeds 25 allowed). Consider refactoring. Wontfix
public function connect(
$dsn = '',
$user = '',
$password = '',
$options = array(),
Method processResult
has 44 lines of code (exceeds 25 allowed). Consider refactoring. Wontfix
private function processResult(string $query, $result = null, bool $isSelect = false)
{
$this->shortcutUsed = false;
// If there is an error then take note of it..
Function connect
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
public function connect(
$dsn = '',
$user = '',
$password = '',
$options = array(),
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method query
has 39 lines of code (exceeds 25 allowed). Consider refactoring. Wontfix
public function query(string $query, bool $use_prepare = false)
{
$param = [];
if ($use_prepare)
$param = $this->prepareValues();
Function query
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
public function query(string $query, bool $use_prepare = false)
{
$param = [];
if ($use_prepare)
$param = $this->prepareValues();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function query_prepared
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
public function query_prepared(string $query, array $param = null, $isSelect = false)
{
$stmt = $this->dbh->prepare($query);
$result = false;
if ($stmt && $stmt->execute(\array_values($param))) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method connect
has 5 arguments (exceeds 4 allowed). Consider refactoring. Wontfix
$dsn = '',
$user = '',
$password = '',
$options = array(),
$isFile = false
Method quick_connect
has 5 arguments (exceeds 4 allowed). Consider refactoring. Wontfix
$dsn = '',
$user = '',
$password = '',
$options = array(),
$isFileBased = false
Identical blocks of code found in 2 locations. Consider refactoring. Open
public function __construct(ConfigInterface $settings = null)
{
if (empty($settings)) {
throw new Exception(\MISSING_CONFIGURATION);
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 119.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76