Sign upLogin

ezSQL/ezsql

View on GitHub
Star
lib/Database/ez_pgsql.php

Summary

Maintainability
C
7 hrs
Test Coverage

Function processQueryResult has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

    private function processQueryResult(string $query, $result = null)
    {
        $this->shortcutUsed = false;

        if (!empty($result))
Severity: Minor
Found in lib/Database/ez_pgsql.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function query has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    public function query(string $query, bool $use_prepare = false)
    {
        $param = [];
        if ($use_prepare) {
            $param = $this->prepareValues();
Severity: Minor
Found in lib/Database/ez_pgsql.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method query has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

    public function query(string $query, bool $use_prepare = false)
    {
        $param = [];
        if ($use_prepare) {
            $param = $this->prepareValues();
Severity: Minor
Found in lib/Database/ez_pgsql.php - About 1 hr to fix

    Method processQueryResult has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Wontfix

        private function processQueryResult(string $query, $result = null)
    {
        $this->shortcutUsed = false;

        if (!empty($result))
    Severity: Minor
    Found in lib/Database/ez_pgsql.php - About 1 hr to fix

      Method quick_connect has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Wontfix

          public function quick_connect($user = '', $password = '', $name = '', $host = 'localhost', $port = '5432')
      Severity: Minor
      Found in lib/Database/ez_pgsql.php - About 35 mins to fix

        Method connect has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Wontfix

                string $user = '',
        string $password = '',
        string $name = '',
        string $host = 'localhost',
        string $port = '5432'
        Severity: Minor
        Found in lib/Database/ez_pgsql.php - About 35 mins to fix

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

              public function __construct(ConfigInterface $settings = null)
    {
        if (empty($settings)) {
            throw new Exception(\MISSING_CONFIGURATION);
        }
          Severity: Major
          Found in lib/Database/ez_pgsql.php and 2 other locations - About 1 hr to fix
          lib/Database/ez_mysqli.php on lines 38..50
          lib/Database/ez_sqlsrv.php on lines 47..59

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 106.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (!empty($param) && \is_array($param) && ($this->isPrepareOn())) {
            $this->shortcutUsed = true;
            $this->result = $this->query_prepared($query, $param);
        } else {
            try {
          Severity: Minor
          Found in lib/Database/ez_pgsql.php and 1 other location - About 40 mins to fix
          lib/Database/ez_sqlsrv.php on lines 304..313

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 94.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status