Sign upLogin

ezpaarse-project/ezpaarse

View on GitHub
Star

Showing 274 of 274 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

list.remove = function (username, callback) {
  mongo.getCollection('users').deleteOne({ username: username })
    .then((v) => callback(undefined, v))
    .catch((e) => callback(e, undefined));
};
Severity: Major
Found in lib/userlist.js and 2 other locations - About 2 hrs to fix
lib/password.js on lines 20..24
lib/userlist.js on lines 48..52

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 76.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

pwd.getUser = function (uuid, callback) {
  mongo.getCollection('users').findOne({ uuid })
    .then((v) => callback(undefined, v))
    .catch((e) => callback(e, undefined));
};
Severity: Major
Found in lib/password.js and 2 other locations - About 2 hrs to fix
lib/userlist.js on lines 48..52
lib/userlist.js on lines 110..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 76.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function Writer has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var Writer = function (outputStream, outputFields) {
  var self     = this;
  outputFields = outputFields || [];

  outputStream.on('drain', function () {
Severity: Major
Found in lib/outputformats/tsv.js - About 2 hrs to fix

    Function init has 51 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    exports.init = function (callback) {

  externalFactors.forEach(function (factors) {
    if (factors.file) {
      const filepath = path.join(__dirname, '..', factors.file);
    Severity: Major
    Found in lib/ecfilter.js - About 2 hrs to fix

      Function getHeaders has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function getHeaders (settings) {
  if (!settings) { return {}; }
  const headers = {};

  if (settings.outputFormat) { headers['Accept'] = settings.outputFormat; }
      Severity: Minor
      Found in client/store/settings.js - About 2 hrs to fix

        Function addDomainsOf has 50 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          async addDomainsOf(platform) {
    const platformDir  = path.resolve(platformsDir, platform);
    const manifestFile = path.resolve(platformDir, 'manifest.json');
    const parserFile   = path.resolve(platformDir, 'parser.js');
    const pkbFolder    = path.resolve(platformDir, 'pkb');
        Severity: Minor
        Found in lib/parserlist.js - About 2 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (ISSNPattern.test(ridValue)) { // check for ISSN
          var ISSN = ridchecker.getISSN(value);

          if (ISSN.checkable && !ISSN.isValid) {
            nbWarnings++;
          Severity: Major
          Found in lib/pkbvalidator.js and 1 other location - About 2 hrs to fix
          lib/pkbvalidator.js on lines 134..153

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 75.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  } else if (ISBNPattern.test(ridValue)) { // check for ISBN
          var ISBN = ridchecker.getISBN(value);

          if (ISBN.checkable &&  !ISBN.isValid) {
            nbWarnings++;
          Severity: Major
          Found in lib/pkbvalidator.js and 1 other location - About 2 hrs to fix
          lib/pkbvalidator.js on lines 124..153

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 75.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function mail has 49 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            mail: function mail(options) {
    var opts = options || {};

    return {
      send: function (callback) {
          Severity: Minor
          Found in lib/mailer.js - About 1 hr to fix

            Function handleError has 48 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              function handleError(err, ec) {
    ecOrganizer.skip(ec._meta.lineNumber);
    job.logger?.silly(`Organizer: skipping EC #${ec._meta.lineNumber}`);

    switch (err.type) {
            Severity: Minor
            Found in lib/lineprocessor.js - About 1 hr to fix

              Function Organizer has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
              Open

              function Organizer() {
  var self   = this;
  var buffer = new Map();
  var next   = 1;
  var last   = false;
              Severity: Minor
              Found in lib/organizer.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function PROCESS has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
              Open

                  async PROCESS ({ commit, rootState, dispatch }, formData) {
      const headers = await dispatch('settings/GET_HEADERS', null, { root: true });
      const abortController = new AbortController();
      const jobID = uuidv1();
              Severity: Minor
              Found in client/store/process.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function exports has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
              Open

              module.exports = function (req, res, job, next) {
  job.logger?.verbose('Initializing git values');

  git.branch(function (err, str) {
    job.report.set('general', 'git-branch', str || 'N/A');
              Severity: Minor
              Found in lib/init/init-git.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                  format: format.combine(
      format.timestamp(),
      format.splat(),
      format.printf(info => `${info.timestamp} ${info.level}: ${info.message}`)
    ),
              Severity: Major
              Found in lib/job/init.js and 2 other locations - About 1 hr to fix
              lib/job/init.js on lines 190..194
              lib/logger.js on lines 13..17

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 70.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                      format: format.combine(
          format.colorize(),
          format.timestamp(),
          format.printf(info => `${info.timestamp} ${info.level}: ${info.message}`)
        )
              Severity: Major
              Found in lib/job/init.js and 2 other locations - About 1 hr to fix
              lib/job/init.js on lines 183..187
              lib/logger.js on lines 13..17

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 70.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                format: format.combine(
    format.colorize(),
    format.timestamp(),
    format.printf(info => `${info.timestamp} ${info.level}: ${info.message}`)
  ),
              Severity: Major
              Found in lib/logger.js and 2 other locations - About 1 hr to fix
              lib/job/init.js on lines 183..187
              lib/job/init.js on lines 190..194

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 70.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function readFiles has 43 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  (function readFiles() {
      const file = files[i++];
      if (!file) {
        if (options.rewrite === false) { return e.emit('end'); }
        return rewriteFiles();
              Severity: Minor
              Found in lib/pkb-cleaner.js - About 1 hr to fix

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                  case 'text/csv':
    job.logger?.info('CSV requested for response');
    job.headers['Content-Type'] = 'text/csv';
    job.writer = getWriter(getWriterOutputStream('text/csv', 'csv'), 'csv');
                Severity: Major
                Found in lib/init/init-writer.js and 2 other locations - About 1 hr to fix
                lib/init/init-writer.js on lines 146..152
                lib/init/init-writer.js on lines 153..159

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 69.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    UPDATE_CUSTOM_PREDEFINED_SETTINGS (ctx, settings) {
      const { id, fullName, country } = settings;
      return api.updateCustomSettings({
        id,
        fullName,
                Severity: Major
                Found in client/store/settings.js and 1 other location - About 1 hr to fix
                client/store/settings.js on lines 320..328

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 69.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                  case 'application/json':
    job.logger?.info('JSON requested for response');
    job.headers['Content-Type'] = 'application/json';
    job.writer = getWriter(getWriterOutputStream('application/json', 'json'), 'json');
                Severity: Major
                Found in lib/init/init-writer.js and 2 other locations - About 1 hr to fix
                lib/init/init-writer.js on lines 132..138
                lib/init/init-writer.js on lines 153..159

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 69.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Severity
                Category
                Status
                Source
                Language