Sign upLogin

fabiocicerchia/go-proxy-cache

View on GitHub
Star

Showing 11 of 21 total issues

Similar blocks of code found in 4 locations. Consider refactoring.
Open

func InitIpHash(name string, config config.Upstream, enableHealthchecks bool) {
    initLB()
    items := convertEndpoints(config.Endpoints)

    lb[name] = NewIpHashBalancer(name, items)
Severity: Major
Found in server/balancer/balancer.go and 3 other locations - About 35 mins to fix
server/balancer/balancer.go on lines 68..77
server/balancer/balancer.go on lines 80..89
server/balancer/balancer.go on lines 92..101

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

func InitRandom(name string, config config.Upstream, enableHealthchecks bool) {
    initLB()
    items := convertEndpoints(config.Endpoints)

    lb[name] = NewRandomBalancer(name, items)
Severity: Major
Found in server/balancer/balancer.go and 3 other locations - About 35 mins to fix
server/balancer/balancer.go on lines 68..77
server/balancer/balancer.go on lines 92..101
server/balancer/balancer.go on lines 104..113

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

func InitRoundRobin(name string, config config.Upstream, enableHealthchecks bool) {
    initLB()
    items := convertEndpoints(config.Endpoints)

    lb[name] = NewRoundRobinBalancer(name, items)
Severity: Major
Found in server/balancer/balancer.go and 3 other locations - About 35 mins to fix
server/balancer/balancer.go on lines 80..89
server/balancer/balancer.go on lines 92..101
server/balancer/balancer.go on lines 104..113

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

func InitLeastConnection(name string, config config.Upstream, enableHealthchecks bool) {
    initLB()
    items := convertEndpoints(config.Endpoints)

    lb[name] = NewLeastConnectionsBalancer(name, items)
Severity: Major
Found in server/balancer/balancer.go and 3 other locations - About 35 mins to fix
server/balancer/balancer.go on lines 68..77
server/balancer/balancer.go on lines 80..89
server/balancer/balancer.go on lines 104..113

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func SetUpstreamServerHealthChecksHealthy(server string, upstream string) {
    hostname, _ := os.Hostname()
    labels := prometheus.Labels{
        "hostname": hostname,
        "env":      os.Getenv("TRACING_ENV"),
Severity: Minor
Found in telemetry/metrics/metrics.go and 1 other location - About 35 mins to fix
telemetry/metrics/metrics.go on lines 613..625

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 104.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func SetUpstreamServerHealthChecksUnhealthy(server string, upstream string) {
    hostname, _ := os.Hostname()
    labels := prometheus.Labels{
        "hostname": hostname,
        "env":      os.Getenv("TRACING_ENV"),
Severity: Minor
Found in telemetry/metrics/metrics.go and 1 other location - About 35 mins to fix
telemetry/metrics/metrics.go on lines 583..595

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 104.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if err := rdb.getMutex(key).Lock(); err != nil {
        escapedKey := strings.Replace(key, "\n", "", -1)
        escapedKey = strings.Replace(escapedKey, "\r", "", -1)
        rdb.logger.Errorf("Lock Error on %s: %s", escapedKey, err)
        telemetry.From(ctx).RegisterEventWithData("Lock Error", map[string]string{
Severity: Minor
Found in cache/engine/client/client.go and 1 other location - About 30 mins to fix
cache/engine/client/client.go on lines 94..103

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 102.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if ok, err := rdb.getMutex(key).Unlock(); !ok || err != nil {
        escapedKey := strings.Replace(key, "\n", "", -1)
        escapedKey = strings.Replace(escapedKey, "\r", "", -1)
        rdb.logger.Errorf("Unlock Error on %s: %s", escapedKey, err)
        telemetry.From(ctx).RegisterEventWithData("Lock Error", map[string]string{
Severity: Minor
Found in cache/engine/client/client.go and 1 other location - About 30 mins to fix
cache/engine/client/client.go on lines 79..88

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 102.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

func IncUpstreamServerSent(server string, upstream string, val float64) {
    hostname, _ := os.Hostname()
    labels := prometheus.Labels{
        "hostname": hostname,
        "env":      os.Getenv("TRACING_ENV"),
Severity: Minor
Found in telemetry/metrics/metrics.go and 2 other locations - About 30 mins to fix
telemetry/metrics/metrics.go on lines 519..529
telemetry/metrics/metrics.go on lines 532..541

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

func IncUpstreamServerReceived(server string, upstream string, val float64) {
    hostname, _ := os.Hostname()
    labels := prometheus.Labels{
        "hostname": hostname,
        "env":      os.Getenv("TRACING_ENV"),
Severity: Minor
Found in telemetry/metrics/metrics.go and 2 other locations - About 30 mins to fix
telemetry/metrics/metrics.go on lines 506..516
telemetry/metrics/metrics.go on lines 532..541

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

func IncUpstreamServerResponseTime(server string, upstream string, val float64) {
    hostname, _ := os.Hostname()
    labels := prometheus.Labels{
        "hostname": hostname,
        "env":      os.Getenv("TRACING_ENV"),
Severity: Minor
Found in telemetry/metrics/metrics.go and 2 other locations - About 30 mins to fix
telemetry/metrics/metrics.go on lines 506..516
telemetry/metrics/metrics.go on lines 519..529

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language